Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

stream: fix stream not wanted bug #2095

Merged
merged 2 commits into from
Feb 7, 2020
Merged

stream: fix stream not wanted bug #2095

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4406300
stream: fix stream not wanted bug
acud Feb 7, 2020
c171866
stream: fix return on peer send error
acud Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion network/stream/stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,9 @@ func (r *Registry) clientHandleOfferedHashes(ctx context.Context, p *Peer, msg *
if !provider.WantStream(p, w.stream) {
wantedHashesMsg.BitVector = []byte{}
if err := p.Send(ctx, wantedHashesMsg); err != nil {
protocols.Break(fmt.Errorf("sending empty wanted hashes: %w", err))
return protocols.Break(fmt.Errorf("sending empty wanted hashes: %w", err))
}
return nil
}

want, err := bv.New(lenHashes / HashSize)
Expand Down Expand Up @@ -571,6 +572,7 @@ func (r *Registry) clientHandleOfferedHashes(ctx context.Context, p *Peer, msg *
if provider.WantStream(p, w.stream) {
return protocols.Break(errors.New("batch has timed out"))
}
return nil
case <-r.quit:
return nil
case <-p.quit:
Expand Down