Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New metrics #150

Merged
merged 4 commits into from
Feb 15, 2024
Merged

New metrics #150

merged 4 commits into from
Feb 15, 2024

Conversation

0xSulpiride
Copy link
Member

Description

  • added new metrics: bundlesSubmitted, bundlesFailed, useropsInBundle
  • fixed bugs in useropsTimeToProcess
  • updated prom-client version, bc the previous version wasn't handling histograms correctly

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

ch4r10t33r
ch4r10t33r approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xSulpiride 0xSulpiride merged commit b13470d into master Feb 15, 2024
2 of 4 checks passed
@0xSulpiride 0xSulpiride deleted the new-metrics branch February 15, 2024 10:31
@0xSulpiride 0xSulpiride mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xSulpiride @ch4r10t33r