Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid bignumber value - eth_estimateUserOperationGas #168

Closed
wants to merge 1 commit into from

Conversation

saqlain1020
Copy link

@saqlain1020 saqlain1020 commented Mar 27, 2024

Description

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

This update will throw Invalid json error, when not supplied with correct params in userop while estimating gas.
Before this change bundler was returning Bignumber undefined error when CG, VG , PVG etc was not supplied with the userOp, which made it harder to debug.

Added invalid json error, when not supplying correct params in userop when estimating gas.
@saqlain1020 saqlain1020 changed the title fix: Invalid Bignumber value - eth_estimateUserOperationGas fix: invalid bignumber value - eth_estimateUserOperationGas Mar 27, 2024
@0xSulpiride
Copy link
Member

0xSulpiride commented Apr 24, 2024

Thanks for reporting the issue! We should keep these fields optional as per the EIP. I investigated the issue and fixed it in this PR - #170

@saqlain1020

@saqlain1020
Copy link
Author

@0xSulpiride Understood 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[ERROR] Invalid Bignumber value - eth_estimateUserOperationGas
2 participants