-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intToBuffer() fails for numbers that produce odd length hex strings #8
Comments
This is breaking a lot more then just the above mentioned modules. I just wanted to sign a Transaction with ethereumjs-tx, which produced a wrong transaction now! As a workaround I'm just using now Version 0.1.4 again. |
This small bug spoils entire ethereumjs libraries. Please fix this issue as soon as possible. I have already wasted 1 day to fix this bug on my project. |
Will fix in 20 minutes
…Sent from my iPhone
On Jun 10, 2018, at 1:22 PM, Chandra Nakka ***@***.***> wrote:
This small bug spoils entire ethereumjs libraries. Please fix this issue as soon as possible. I have already wasted 1 day to fix this bug on my project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@vpulim should be up in NPM ethjs-util@0.1.6 @ChandraNakka @simon-jentzsch |
@SilentCicero still is not fixed, since |
Will fix now and push. Thanks
…Sent from my iPhone
On Jun 10, 2018, at 3:42 PM, Kirill Fomichev ***@***.***> wrote:
@SilentCicero still is not fixed, since lib/index.js still is not changed. Please push new version and unpublish 2 previous versions with npm unpublish. Also please push last changes to repo.
This breaks a really lot of things in ETH libraries...
@ChandraNakka @simon-jentzsch I'd recommmend use npm/yarn lock file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@fanatid the module I pushed has the updated lib/index.js code in version 0.1.6:
Can you please expand where the module is failing, please try installing the new version again. |
Very strange. Sorry, looks like I was on @0.1.5 when tested (i.e. install dependencies for ethereumjs-tx before 0.1.6 was published). |
I will depreciate. |
Not everybody read messages in console, since this library is used in applications which operate with big amounts of money, I think unpublish will be appropriate. |
Okay, will u publish .5 and .4
…Sent from my iPhone
On Jun 10, 2018, at 4:53 PM, Kirill Fomichev ***@***.***> wrote:
Not everybody read messages in console, since this library is used in applications which operate with big amounts of money, I think unpublish will be appropriate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@SilentCicero Thanks a lot, now it's working :) |
So sorry about that! Clearly not enough test coverage over these basic methods. Will update coverage soon.
…Sent from my iPhone
On Jun 11, 2018, at 1:17 AM, Chandra Nakka ***@***.***> wrote:
@SilentCicero Thanks a lot, now it's working :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
ethjs-util
Issue Type
Description
The intToBuffer() function is broken after this PR was merged: #7
It fails for numbers that don't produce an even length hex string. It's breaking the following modules:
Steps to reproduce
Versions
The text was updated successfully, but these errors were encountered: