Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPFS node to circle environment #86

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Aug 10, 2018

What was wrong?

Better testing of IPFS integration was needed.

How was it fixed?

Configured circle to start a ci node in the background we can run some integration tests against

Cute Animal Picture

image

@njgheorghita njgheorghita force-pushed the ipfs-ci branch 16 times, most recently from 5eebe14 to d328036 Compare August 10, 2018 18:04
@njgheorghita njgheorghita changed the title WIP - dirty Add IPFS node to circle environment Aug 10, 2018
@njgheorghita
Copy link
Contributor Author

@pipermerriam Not sure what's the best way forward here. Circle now has an ipfs node available to run integration tests against. But, the tests will fail if a user runs them locally and doesn't have their own IPFS node running. Thoughts?

@pipermerriam
Copy link
Member

I'd lump the tests into a separate test run and then add a pytest cli argument like this: https://github.com/ethereum/py-evm/blob/master/tests/trinity/conftest.py#L27-L29. You can then conditionally skip the tests based on the presence of that flag. Probably good to document this in the developer documentation.

@njgheorghita njgheorghita force-pushed the ipfs-ci branch 11 times, most recently from f847a49 to f2413dc Compare August 11, 2018 14:18
@njgheorghita njgheorghita force-pushed the ipfs-ci branch 23 times, most recently from 768b982 to 90444ad Compare August 11, 2018 16:55
@njgheorghita
Copy link
Contributor Author

njgheorghita commented Aug 11, 2018

@pipermerriam Thanks, made the change. I was getting some weird behavior with Circle for a bit where it wasn't recursing through all the test files after adding the --integration flag to the pytest command, so I added tests/ to the command and it seems to be working fine now.

@njgheorghita njgheorghita merged commit 5f8a71b into ethpm:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants