Skip to content

Commit

Permalink
Remove form validation to allow both email & phone inputs for consent…
Browse files Browse the repository at this point in the history
… requests (#3529)
  • Loading branch information
NevilleS committed Jun 11, 2023
1 parent ed256ed commit 41e3676
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -63,6 +63,7 @@ The types of changes are:
- Update privacy centre email and phone validation to allow for both to be blank [#3432](https://github.com/ethyca/fides/pull/3432)
- Moved connection configuration into the system portal [#3407](https://github.com/ethyca/fides/pull/3407)
- Update `fideslang` to `1.4.1` to allow arbitrary nested metadata on `System`s and `Dataset`s `meta` property [#3463](https://github.com/ethyca/fides/pull/3463)
- Remove form validation to allow both email & phone inputs for consent requests [#3529](https://github.com/ethyca/fides/pull/3529)

### Developer Experience

Expand Down
Expand Up @@ -240,9 +240,6 @@ const ConsentRequestForm: React.FC<ConsentRequestFormProps> = ({
onBlur={handleBlur}
value={values.email}
isInvalid={touched.email && Boolean(errors.email)}
isDisabled={Boolean(
typeof values.phone !== "undefined" && values.phone
)}
/>
<FormErrorMessage>{errors.email}</FormErrorMessage>
</FormControl>
Expand All @@ -252,9 +249,6 @@ const ConsentRequestForm: React.FC<ConsentRequestFormProps> = ({
id="phone"
isInvalid={touched.phone && Boolean(errors.phone)}
isRequired={identityInputs.phone === "required"}
isDisabled={Boolean(
typeof values.email !== "undefined" && values.email
)}
>
<FormLabel fontSize="sm">Phone</FormLabel>
<PhoneInput
Expand Down

0 comments on commit 41e3676

Please sign in to comment.