Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove form validation to allow both email & phone inputs for consent requests #3529

Merged
merged 2 commits into from Jun 11, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Jun 11, 2023

Code Changes

  • Remove form logic that would force only a single phone or email input to be provided

Steps to Confirm

  • Configure privacy center with both phone and email inputs as optional for consent requests
  • Test all permutations:
    • Neither email nor phone
    • Only email
    • Only phone
    • Both email and phone

Pre-Merge Checklist

Description Of Changes

In #3432 we reintroduced the ability to collect multiple identity inputs on consent requests, which reversed most of the changes in #2539

However, even though #3432 restored the ability to collect both email & phone, it didn't remove the form validation, so if you tried to type in both the email & phone fields they would still disable each other!

For example, this screenshot shows where I've typed in the email field, but the phone number field then gets disabled:
image

This change just removes that isDisabled logic to allow both fields to be populated simultaneously.

@NevilleS NevilleS changed the title Allow multiple identity inputs for consent requests Remove form validation that prevents both email & phone inputs for consent requests Jun 11, 2023
@NevilleS NevilleS changed the title Remove form validation that prevents both email & phone inputs for consent requests Remove form validation to allow both email & phone inputs for consent requests Jun 11, 2023
@cypress
Copy link

cypress bot commented Jun 11, 2023

Passing run #2618 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8c4c147 into c776827...
Project: fides Commit: 89c1063697 ℹ️
Status: Passed Duration: 00:50 💡
Started: Jun 11, 2023 10:14 PM Ended: Jun 11, 2023 10:14 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@NevilleS NevilleS merged commit db8cd88 into main Jun 11, 2023
11 checks passed
@NevilleS NevilleS deleted the ns-allow-multiple-identity-inputs branch June 11, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant