Segment Integration: user_id over email #5004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #8928 ↗︎
Details:
Review all test suite changes for PR #5004 ↗︎ |
||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5004 +/- ##
=======================================
Coverage 86.44% 86.44%
=======================================
Files 354 354
Lines 22201 22201
Branches 2925 2925
=======================================
Hits 19192 19192
Misses 2495 2495
Partials 514 514 ☔ View full report in Codecov by Sentry. |
SteveDMurphy
commented
Jun 20, 2024
| fidesops_meta: | ||
| fides_meta: | ||
| data_type: string | ||
| - name: first_name |
There was a problem hiding this comment.
additional fields found in testing (these may be configurable by client?)
SteveDMurphy
commented
Jun 20, 2024
| identity: email | ||
| references: | ||
| - dataset: <instance_fides_key> | ||
| field: traits.user_id |
There was a problem hiding this comment.
I chose to use the traits, but it could also be that we use external_ids however it will end up generating extra requests so decided against it for the time being
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FIDES-746
Description Of Changes
It's been determined that the email cannot be used as the identity unless it is also the user_id. For this we need to infer the user_id from either traits or external_ids
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works