-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment Integration: user_id over email #5004
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
92359d1
feat: update segment erasure to use user_id
SteveDMurphy f187316
Merge branch 'main' into SteveDMurphy-segment-erase-user-id
SteveDMurphy 62dfb1c
Merge branch 'main' into SteveDMurphy-segment-erase-user-id
SteveDMurphy 50519b4
Merge branch 'main' into SteveDMurphy-segment-erase-user-id
SteveDMurphy bb08187
fix: add primary key to dataset, bump version
SteveDMurphy d3e77ae
changelog
SteveDMurphy 7d5ce20
Merge branch 'main' into SteveDMurphy-segment-erase-user-id
SteveDMurphy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,6 @@ dataset: | |
fields: | ||
- name: segment_id | ||
data_categories: [user.unique_id] | ||
fidesops_meta: | ||
primary_key: True | ||
SteveDMurphy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: track_events | ||
fields: | ||
- name: external_ids | ||
|
@@ -25,7 +23,7 @@ dataset: | |
fields: | ||
- name: name | ||
data_categories: [user.name] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: version | ||
data_categories: [system.operations] | ||
|
@@ -57,19 +55,19 @@ dataset: | |
fields: | ||
- name: city | ||
data_categories: [user.contact.address.city] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: country | ||
data_categories: [user.contact.address.country] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: postalCode | ||
data_categories: [user.contact.address.postal_code] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: state | ||
data_categories: [user.contact.address.state] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: age | ||
data_categories: [user.demographic.age_range] | ||
|
@@ -81,41 +79,55 @@ dataset: | |
data_categories: [user] | ||
- name: email | ||
data_categories: [user.contact.email] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: firstName | ||
data_categories: [user.name] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: first_name | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. additional fields found in testing (these may be configurable by client?) |
||
data_categories: [user.name] | ||
fides_meta: | ||
data_type: string | ||
- name: gender | ||
data_categories: [user.demographic.gender] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: id | ||
data_categories: [user.unique_id] | ||
fides_meta: | ||
primary_key: true | ||
SteveDMurphy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: industry | ||
data_categories: [system.operations] | ||
- name: lastName | ||
- name: last_name | ||
data_categories: [user.name] | ||
fides_meta: | ||
data_type: string | ||
- name: name | ||
data_categories: [user.name] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: phone | ||
data_categories: [user.contact.phone_number] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: subscriptionStatus | ||
- name: title | ||
data_categories: [user.name] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: username | ||
data_categories: [user.name] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: website | ||
data_categories: [user] | ||
fidesops_meta: | ||
fides_meta: | ||
data_type: string | ||
- name: user_id | ||
data_categories: [user.unique_id] | ||
fides_meta: | ||
data_type: string | ||
- name: external_ids | ||
fields: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to use the traits, but it could also be that we use
external_ids
however it will end up generating extra requests so decided against it for the time being