Include Tests in static code analysis #558
Conversation
To make this work, we needed to disable checks for missing-docstring and redefined-outer-name. The first for being irrelevant and the second for conflicting with how pytest actually works, returning a false negative. The remainder of the changes are potential corrections for the relevant pylint errors remaining.
Somehow these were not caught in our CI checks, although they should have.
|
@ThomasLaPiana I found that the CI checks were passing with just a help message as part of this PR, currently working through it but may need a second set of eyes if I get stuck on anything here much longer. We may want to hold off on other dependency version bumping as well |
SteveDMurphy
force-pushed
the
SteveDMurphy-535-testing-of-tests
branch
from
60bbdaa
to
584b780
Compare
Co-authored-by: Eduardo Armendariz <eduardo@ethyca.com>
|
Thanks for the help on the external test issue I caused @earmenda ! @ThomasLaPiana this one is large in file size but really the only |
|
@SteveDMurphy no worries! it do be like that sometimes :) Thanks for the changes and the catch on that tricky nox bug! |
|
pulled locally and testing now |
|
@SteveDMurphy herculean effort, thanks for knocking this one out! |
|
confirmed |
This was missed in #558 as part of the static code validation updates. Updating the param should fix the docs build failure, no update to the check should be necessary at this point.
This was missed in #558 as part of the static code validation updates. Updating the param should fix the docs build failure, no update to the check should be necessary at this point.
Closes #535
Code Changes
--no-ttyto-Tso checks run againSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
pylint
To make this work, we needed to disable checks for missing-docstring and redefined-outer-name. The first for being irrelevant and the second for conflicting with how pytest actually works, returning a false negative. The remainder of the changes are potential corrections for the relevant pylint errors remaining.
mypy
At the first pass, over 200 errors were found across more than 20 files. This was more of a blitz to get all of the type hinting correct without taking time to look for any other testing consolidation etc.