Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Unify ExecutionLog and AuditLog into a single endpoint with grouping at request level #1024

Closed
seanpreston opened this issue Aug 2, 2022 · 0 comments · Fixed by #1068
Closed
Assignees
Labels
enhancement New feature or request

Comments

@seanpreston
Copy link
Contributor

seanpreston commented Aug 2, 2022

Description

In designs we want to give a time series of the life of a subject request. This includes both submitted, approval info and execution level information.
To support our front end users and organize the information well, we need to unify/combine this information into a single endpoint.

Notes

  • Consider over indexing on exposing execution logs
  • FE assumes the log comes back in a way that assumes we have the datastore info - we may need a subsequent ticket to update the FE based on the outputs of this ticket. Test this with the FE when merging.
  • include pagination on this endpoint.
@seanpreston seanpreston added the enhancement New feature or request label Aug 3, 2022
TheAndrewJackson pushed a commit that referenced this issue Aug 15, 2022
…1068)

* Update the request status endpoint, so when the verbose query param is used and execution logs are embedded, also return audit logs.

Execution Logs are created at the collection level while audit logs are for the overall privacy request level, so most fields returned for audit logs are None.
Logs are also grouped at the dataset level here, so give the audit logs a fake dataset name for display purposes, for example, "Request approved".

* Update CHANGELOG and update docs to reflect that audit logs are included in a verbose request status response.
sanders41 pushed a commit that referenced this issue Sep 22, 2022
…1068)

* Update the request status endpoint, so when the verbose query param is used and execution logs are embedded, also return audit logs.

Execution Logs are created at the collection level while audit logs are for the overall privacy request level, so most fields returned for audit logs are None.
Logs are also grouped at the dataset level here, so give the audit logs a fake dataset name for display purposes, for example, "Request approved".

* Update CHANGELOG and update docs to reflect that audit logs are included in a verbose request status response.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants