Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

pass in analytics id env to worker #1113

Merged
merged 2 commits into from
Aug 19, 2022
Merged

pass in analytics id env to worker #1113

merged 2 commits into from
Aug 19, 2022

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Aug 19, 2022

Purpose

Enable worker running in separate docker container to properly receive the FIDESOPS__ROOT_USER__ANALYTICS_ID env var

Changes

  • Add env var to docker-compose.yml

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1103

@seanpreston seanpreston requested review from PSalant726 and removed request for PSalant726 August 19, 2022 15:12
@seanpreston seanpreston self-assigned this Aug 19, 2022
@seanpreston
Copy link
Contributor

Great detective work @eastandwestwind

@seanpreston seanpreston merged commit d19d556 into main Aug 19, 2022
@seanpreston seanpreston deleted the 1103-analytics-env-var branch August 19, 2022 20:34
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* pass in analytics id env to worker

* changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENV vars need to take precedence over config vars
2 participants