Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of function to extend keypoints #32

Closed
wants to merge 2 commits into from

Conversation

mbuerki
Copy link
Contributor

@mbuerki mbuerki commented Nov 8, 2018

No description provided.

@schneith
Copy link

schneith commented Nov 8, 2018

mh, that looks like quite a bad bug. good catch :)
does it improve the tracking?

schneith
schneith previously approved these changes Nov 8, 2018
@mbuerki
Copy link
Contributor Author

mbuerki commented Nov 8, 2018

@schneith if this branch of the if block is executed, it inevitably segfaults. that's why I'm pretty sure we haven't had any actively used part of the code actually executing that branch, which is both good and bad I guess :-|
I mean the reason is that we usually don't detect keypoints twice for the same frame and then keep both sets of keypoints (i.e, extending existing keypoints with more) - something which I can hardly find a good reason to do anyways. So I'm very much wondering if we shouldn't just kill that function altogether (there's already one for inserting keypoints into an empty frame).
Or do you see a good reason to keep it?

@schneith
Copy link

schneith commented Nov 8, 2018

ah too bad, some free tracker improvements would have been great :)
I don't see a reason to keep it if it is not used. Let's remove it then?

@mbuerki mbuerki changed the title addressing bug in block assignment for extending keypoints Removal of function to extend keypoints Nov 9, 2018
@mbuerki
Copy link
Contributor Author

mbuerki commented Nov 9, 2018

closing this, reopened here #33

@mbuerki mbuerki closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants