Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline fails with data selection #187

Closed
Jaeyoung-Lim opened this issue Feb 16, 2022 · 1 comment
Closed

Pipeline fails with data selection #187

Jaeyoung-Lim opened this issue Feb 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Jaeyoung-Lim
Copy link
Member

Jaeyoung-Lim commented Feb 16, 2022

Problem Description
When manually selecting data using the data selection tool, the pipeline fails with the following error

-------------------------------------------------------------------------------
                            Optimization Metrics                               
-------------------------------------------------------------------------------
R2: 0.9998888927269959
RMSE: 0.058325590518898365

-------------------------------------------------------------------------------
Complete results saved to: 
model_results/multirotor_model_2022-02-16-13-46-30.yaml
-------------------------------------------------------------------------------
Traceback (most recent call last):
  File "Tools/parametric_model/generate_parametric_model.py", line 117, in <module>
    start_model_estimation(**vars(arg_list))
  File "Tools/parametric_model/generate_parametric_model.py", line 99, in start_model_estimation
    model.compute_residuals()
  File "/home/jaeyoung/dev/data-driven-dynamics/Tools/parametric_model/src/models/dynamics_model.py", line 486, in compute_residuals
    y_forces_pred[2::3] = y_pred[int(2*self.y_forces.shape[0]/3):self.y_forces.shape[0]]
ValueError: could not broadcast input array from shape (5414) into shape (14075)
Makefile:34: recipe for target 'estimate-model' failed
make: *** [estimate-model] Error 1

It appears that the residual calculation is done on the full log, while the predictions are done on the selected data, which was added in #182

@Jaeyoung-Lim Jaeyoung-Lim added the bug Something isn't working label Feb 16, 2022
@Jaeyoung-Lim
Copy link
Member Author

Fixed in #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant