Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera model pinhole-none #574

Open
subutayebru opened this issue Oct 25, 2022 · 1 comment
Open

camera model pinhole-none #574

subutayebru opened this issue Oct 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@subutayebru
Copy link

subutayebru commented Oct 25, 2022

Hi!

I am having an issue that pinhole camera model none distortion configuration on kalibr using ros package, not the docker.

$rosrun kalibr  kalibr_calibrate_cameras --target ~/Calibration_Ebru/apriltag_045_printed.yaml --bag ~/Calibration_Ebru/2022-10-23-16-06-35.bag --models pinhole-none --topics /camera/color/image_raw --show-extraction --verbose

importing libraries
Initializing cam0:
	Camera model:	  pinhole-none
Traceback (most recent call last):
  File "/home/bru/catkin_ws/src/kalibr/aslam_offline_calibration/kalibr/python/kalibr_calibrate_cameras", line 449, in <module>
    main()
  File "/home/bru/catkin_ws/src/kalibr/aslam_offline_calibration/kalibr/python/kalibr_calibrate_cameras", line 194, in main
    raise RuntimeError( "Unknown camera model: {0}. Try {1}.".format(modelName, list(cameraModels.keys())) )
RuntimeError: Unknown camera model: pinhole-none. Try ['pinhole-radtan', 'pinhole-equi', 'omni-radtan', 'pinhole-fov', 'ds-none', 'omni-none', 'eucm-none']. 

In kalibr _calibrate_cameras.py there are available models:


#available models
cameraModels = { 'pinhole-radtan': acvb.DistortedPinhole,
                 'pinhole-equi':   acvb.EquidistantPinhole,
                 'pinhole-fov':    acvb.FovPinhole,
                 'omni-none':      acvb.Omni,
                 'omni-radtan':    acvb.DistortedOmni,
                 'eucm-none':      acvb.ExtendedUnified,
                 'ds-none':        acvb.DoubleSphere}

How to add pinhole-none to the script?

Ros version: Melodic

@NikolausDemmel
Copy link
Contributor

It will require some code changes. You could have a look at this PR, which added new camera models, for some pointers where you might have to add things to enable pinhole-none: #210

Note that your diff will be much simpler of course, since you're not implementing a new model, just enabling a new combination of existing model and distortion. You will only have to touch a subset of the places touched by above PR.

@goldbattle goldbattle added the question Theory or implementation question label Oct 30, 2022
@goldbattle goldbattle added enhancement New feature or request and removed question Theory or implementation question labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants