Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supports PointCloud2 messages with RGB field #366

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Conversation

hermannsblum
Copy link
Contributor

So far, only the "rgba" field is supported. This adds support for the "rgb" field for PointCloud2, similar to what already exists for PointCloud messages.

Here is a map with pointclouds from the azure kinect:

Screenshot from 2022-10-27 18-01-20

@ethzasl-jenkins
Copy link

Test FAILed.

@ethzasl-jenkins
Copy link

Test PASSed.

@smauq smauq changed the base branch from develop to master April 18, 2023 18:51
@ethz-asl ethz-asl deleted a comment from ethzasl-jenkins Apr 18, 2023
Copy link
Member

@smauq smauq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! Did a few changes to the formatting

@ethzasl-jenkins
Copy link

Test FAILed.

@ethzasl-jenkins
Copy link

Test PASSed.

@smauq smauq merged commit 24a56d3 into master Apr 19, 2023
@smauq smauq deleted the feature/pc2-with-rgb branch April 19, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants