Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-atomic option for buildwatson #229

Merged
merged 12 commits into from
Dec 7, 2017

Conversation

dustinrb
Copy link

@dustinrb dustinrb commented Dec 6, 2017

Although having buildwatson add SearchEntries entries atomically is preferable, adding batches of SearchEntries to the database can help the index build successfully complete for large indexes (>1 GB).

This PR adds two flags to buildwatson:

  • --non_atomic: Submits each batch in a non-atomic transaction. It will create and incomplete index if buildwatson fails but may help with make large indexing jobs more stable.

  • --batch_size=100: Changes the batch size buildwatson uses to add entries to the database.

@etianen etianen merged commit c8fcb69 into etianen:master Dec 7, 2017
@amureki
Copy link
Contributor

amureki commented Dec 11, 2017

@dustinrb @etianen wiki/docs update would be good for this one. :)

@dustinrb
Copy link
Author

I'm happy to write some brief documentation. I can expand the "Manually updating the search indexes" subsection of the Registering Models section on the wiki. Let me know if you can think of a better place to put this information.

@etianen
Copy link
Owner

etianen commented Dec 12, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants