-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-atomic option for buildwatson #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm happy to write some brief documentation. I can expand the "Manually updating the search indexes" subsection of the Registering Models section on the wiki. Let me know if you can think of a better place to put this information. |
Maybe a new wiki page dedicated to management commands would be good?
…On 11 December 2017 at 23:19, Dustin Broderick ***@***.***> wrote:
I'm happy to write some brief documentation. I can expand the "Manually
updating the search indexes" subsection of the *Registering Models*
section on the wiki. Let me know if you can think of a better place to put
this information.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#229 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJFCI9p76wSt5NqFFRvCEeEjhrSuzMgks5s_biUgaJpZM4Q4Yic>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although having
buildwatson
add SearchEntries entries atomically is preferable, adding batches of SearchEntries to the database can help the index build successfully complete for large indexes (>1 GB).This PR adds two flags to
buildwatson
:--non_atomic
: Submits each batch in a non-atomic transaction. It will create and incomplete index ifbuildwatson
fails but may help with make large indexing jobs more stable.--batch_size=100
: Changes the batch sizebuildwatson
uses to add entries to the database.