Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matching on record name #80

Closed
etianen opened this issue Feb 5, 2024 · 0 comments · Fixed by #134
Closed

Allow matching on record name #80

etianen opened this issue Feb 5, 2024 · 0 comments · Fixed by #134
Labels
enhancement New feature or request

Comments

@etianen
Copy link
Owner

etianen commented Feb 5, 2024

This would require capturing name and add a new name argument to the logged APIs.

@etianen etianen added the enhancement New feature or request label Feb 5, 2024
etianen added a commit that referenced this issue Feb 9, 2024
This will allow parity when matching on `LogRecord.name` (see #80). It's
also more applicable to terms used in 3rd-party logging frameworks (e.g.
`loguru`).
etianen added a commit that referenced this issue Feb 25, 2024
This will make adding new features such as #25, #26 and #80 easier.

It also opens the door to #31 and #124, if desired in future.
etianen added a commit that referenced this issue Feb 25, 2024
This reduces LOC and manual boilerplate for `__eq__` and `__init__`.

This will make adding new features such as #25, #26 and #80 easier.
etianen added a commit that referenced this issue Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant