Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ELLIPSIS marker #124

Closed
ArneBachmannDLR opened this issue Feb 23, 2024 · 2 comments
Closed

Support ELLIPSIS marker #124

ArneBachmannDLR opened this issue Feb 23, 2024 · 2 comments
Labels
question Further information is requested wontfix This will not be worked on

Comments

@ArneBachmannDLR
Copy link

With using doctest you can use ... to mean regex-like .* catchall.
When converting to logot I stumbled upon AssertionError: Not logged: until realizing I had ... inside the expected output.

@ArneBachmannDLR
Copy link
Author

Just found out about https://logot.readthedocs.io/latest/log-message-matching.html which wasn't clear from the Github README alone, that solved my issue. Above idea may still be interesting.

@etianen etianen added the question Further information is requested label Feb 24, 2024
@etianen etianen added the wontfix This will not be worked on label Feb 24, 2024
etianen added a commit that referenced this issue Feb 24, 2024
This should hopefully help people find things. See #124
@etianen
Copy link
Owner

etianen commented Feb 24, 2024

I've flirted with the idea of supporting alternate match syntax (see #31). If there was demand for this, I'd consider making a generic mechanism to match using other syntaxes, of which ... would be a good option.

I'm marking this idea as wontfix for now, as there are no immediate plans. If other people stumble upon this issue and think it would be worthwhile, however, feel free to comment and we can think about ways it could be implemented! ❤️

Meanwhile, I've updated the README with some deep links to the logot docs (see #125). Hopefully this will help other people find the log message matching docs in future! 🙇

@etianen etianen closed this as completed Feb 24, 2024
@etianen etianen closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2024
etianen added a commit that referenced this issue Feb 25, 2024
This will make adding new features such as #25, #26 and #80 easier.

It also opens the door to #31 and #124, if desired in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants