Some fixes in vignettes handling #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
etiennebacher
commented
Apr 21, 2023
etiennebacher
commented
- Do not try to automatically include vignettes in the website structure: 1) this was done in a very clumsy way and 2) most of the time it is better to let authors order the vignettes as they want
- Always render vignettes, even if their content wasn't modified. A vignette may not change but still functions used inside can produce a different output. It is much safer to always render vignettes (also allows authors to catch errors)
✅ Deploy Preview for upbeat-hamilton-47df84 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.