Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pysnmp backend not to produce over 255 args in function calls #16

Merged
merged 4 commits into from
Nov 6, 2017

Conversation

etingof
Copy link
Owner

@etingof etingof commented Nov 2, 2017

This PR brings a handful of fixes to make sure that pysnmp codegen does not produce more than 255 params in func calls what makes generated Python code failing to compile.

@etingof etingof mentioned this pull request Nov 2, 2017
@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #16 into master will decrease coverage by 0.32%.
The diff coverage is 65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage    60.8%   60.47%   -0.33%     
==========================================
  Files          30       30              
  Lines        2847     2877      +30     
==========================================
+ Hits         1731     1740       +9     
- Misses       1116     1137      +21
Impacted Files Coverage Δ
pysmi/codegen/pysnmp.py 80.45% <65%> (-2.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9341983...1d7ca20. Read the comment docs.

@etingof etingof merged commit 42232c3 into master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants