server: Never set lastTime=0 for leaky buckets as it may cause leaking

of leaky buckets :p refs #541
etlegacy · Feb 4, 2018 · 8120de3 · 8120de3
1 parent 850f9c7
commit 8120de3
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/server/sv_main.c b/src/server/sv_main.c
@@ -623,6 +623,9 @@ static leakyBucket_t *SVC_BucketForAddress(netadr_t address, int burst, int peri
 		}
 	}
 
+	// make sure we will never use time 0
+	now = now ? now : 1;
+
 	for (i = 0; i < MAX_BUCKETS; i++)
 	{
 		int interval;
@@ -631,7 +634,7 @@ static leakyBucket_t *SVC_BucketForAddress(netadr_t address, int burst, int peri
 		interval = now - bucket->lastTime;
 
 		// Reclaim expired buckets
-		if (bucket->lastTime > 0 && (interval > (burst * period) || interval < 0))
+		if (bucket->lastTime > 0 && (unsigned) interval > (burst * period))
 		{
 			if (bucket->prev != NULL)
 			{