Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/extend hitsounds #1201

Closed
ETLegacyTeam opened this issue Mar 5, 2020 · 0 comments
Closed

Improve/extend hitsounds #1201

ETLegacyTeam opened this issue Mar 5, 2020 · 0 comments
Labels
🐞 Bug Something isn't working cat: mod Category mod (generic) P2: High Priority 2
Milestone

Comments

@ETLegacyTeam
Copy link
Member

ETLegacyTeam commented Mar 5, 2020

Author: @IR4T4 (IR4T4)
Date: 2019-02-08
Redmine Issue: 1201, https://dev.etlegacy.com/issues/1201


I've just remembered the current hitsound implementation is based on 'client' side (see ps->persistant[PERS_HITS]) to save resources (no extra events for hitsounds). For this the server has to count and send the updated PERS_HITS which is causing a short delay.

Hitsounds can be also done 'server' side see ETPub implementation of G_doHitSound (-> G_ClientSound -> new event)

We might change the code so both ways are available.


Related issue(s): #507, #1200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working cat: mod Category mod (generic) P2: High Priority 2
Projects
None yet
Development

No branches or pull requests

2 participants