Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cgame/qgame version check #1225

Open
ETLegacyTeam opened this issue Mar 5, 2020 · 3 comments
Open

Add cgame/qgame version check #1225

ETLegacyTeam opened this issue Mar 5, 2020 · 3 comments
Labels
cat: mod Category mod (generic) P3: Normal Priority 3 📝 Task Indirectly related to code: libs update, documentation
Milestone

Comments

@ETLegacyTeam
Copy link
Member

ETLegacyTeam commented Mar 5, 2020

Author: @rmarquis (Spyhawk)
Date: 2019-03-20
Redmine Issue: 1225, https://dev.etlegacy.com/issues/1225


Version string of UI/cgame/qgame are displayed in console by default.
Try checking for cgame/qgame version match, and print a warning if that isn't the case (console, or maybe even in the center screen?).


Related commit(s):
e8fec93 - mod: added mod version mismatch check, fixes 1225..
50c4a35 - game: ensure dropped client isn't processed, refs ..
f335fe7 - misc: use fixed git version length, refs 1225
7134696 - mod: revert cgame/game version check, refs 1225"..
ea44ba9 - client: store engine and mod versions in userinfo,..
17ee01f - general: add engine version verification facility,..
3c14fb6 - game: added cg_etVersion info display in /players
6f1da27 - game: fixed version info display in /players for b..
6319f49 - client: fix regression where on server disconnect ..
e9489ee - general: fixed engine client version overwritten i..
6a1eab0 - client: removed now unnecessary etVersion in clien..

@ETLegacyTeam ETLegacyTeam added cat: mod Category mod (generic) P3: Normal Priority 3 📝 Task Indirectly related to code: libs update, documentation labels Mar 5, 2020
@ETLegacyTeam ETLegacyTeam added this to the Future milestone Mar 5, 2020
@ETLegacyTeam
Copy link
Member Author

From: @rmarquis (Spyhawk)
Date: 2019-03-28T09:08:42Z


See the already implemented (but disabled) G_CheckVersion() function.
Rather than a print, drop the client with a clean message (better than the actual "unknown event 67").

@ETLegacyTeam
Copy link
Member Author

From: @rmarquis (Spyhawk)
Date: 2019-04-26T22:05:07Z


Applied in changeset commit:e8fec93efc31996db725a0534e2ffe590e6aee2b.

@ETLegacyTeam
Copy link
Member Author

From: @rmarquis (Spyhawk)
Date: 2019-04-30T16:00:47Z


Note: Newer git versions (2.11) seem to have a different output than older version (f.e. 2.5), with 8 hex digits rather than 7 (dynamic length). This is problematic when compiling the game on older platforms like CentOS 7.

Edit: thie is also problematic when used as a dev, with older downloaded bin versions preventing dev version to be launched locally. Inspect again once the contanerized FS is fully implemented.

Also, the engine version check might actually be important to keep (2.55?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: mod Category mod (generic) P3: Normal Priority 3 📝 Task Indirectly related to code: libs update, documentation
Projects
None yet
Development

No branches or pull requests

1 participant