Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed physics generate excessive speed #1379

Open
ETLegacyTeam opened this issue Mar 5, 2020 · 1 comment
Open

fixed physics generate excessive speed #1379

ETLegacyTeam opened this issue Mar 5, 2020 · 1 comment
Labels
🐞 Bug Something isn't working cat: mod Category mod (generic) ❓ Feedback Further information is requested P2: High Priority 2
Milestone

Comments

@ETLegacyTeam
Copy link
Member

Author: @isRyven (ryven)
Date: 2019-12-29
Redmine Issue: 1379, https://dev.etlegacy.com/issues/1379


g_fixedphysics generate more speed than pmove_fixed alone, making movement less consistent, for instance some tj tricks are more approachable than they should, and some are failing because you would get damage on landing.

@ETLegacyTeam ETLegacyTeam added 🐞 Bug Something isn't working cat: mod Category mod (generic) P3: Normal Priority 3 labels Mar 5, 2020
@ETLegacyTeam ETLegacyTeam added this to the 2.77 milestone Mar 5, 2020
@rmarquis rmarquis modified the milestones: 2.77, Future Mar 25, 2020
@rmarquis rmarquis modified the milestones: Future, 2.77 Jan 1, 2021
@rmarquis rmarquis added P2: High Priority 2 and removed P3: Normal Priority 3 labels Jan 3, 2021
@jackeri jackeri modified the milestones: 2.77, 2.78 Mar 1, 2021
@rmarquis rmarquis pinned this issue Mar 23, 2021
@ryzyk-krzysiek
Copy link
Contributor

I tried modifying ryven's patch, which had problem with occasional rubber banding which was seemingly caused by antiwarp. I didn't encounter rubber banding with the code I added to antiwarp but it was hard to encounter it in the first place, so I'm not 100% sure it would be a fix and/or if it would break gameplay too as I didn't test it on server with players. I tried using cg_showmiss but it didn't show any prediction errors with or without the antiwarp code part, even when I was feeling some rubber banding.

Anyway there is much bigger problem I encountered with this patch, maybe I did something wrong since I didn't take all the code from the patch, but only parts that I felt are most relevant and that should have impact on physics.

The problem is that this change affects weapon handling heavily, for example at g_fixedPhysicsFps 333 there is a big delay when weapon switching and time between bullets.

https://streamable.com/5wpfz6

I have no ideas what to do about it.

fixedPhysicsWithAntiwarp.patch.txt

@isRyven any thoughts? :)

Aranud pushed a commit that referenced this issue Apr 12, 2021
…hysics, refs #1379

* game: Changing fixed physics added velocity to emulate framerate-dependent behavior
* game: small improvement and uncrustify
@rmarquis rmarquis modified the milestones: 2.78, 2.79 Sep 28, 2021
@jackeri jackeri modified the milestones: 2.79, 2.80 Dec 23, 2021
@Aranud Aranud modified the milestones: 2.80, Future Apr 11, 2022
@Aranud Aranud added the ❓ Feedback Further information is requested label Jan 16, 2023
@Aranud Aranud modified the milestones: Future, 2.81.0 Jan 16, 2023
@Aranud Aranud removed this from the 2.81.0 milestone Feb 28, 2023
@Aranud Aranud added this to the 2.82.0 milestone Feb 28, 2023
@Aranud Aranud modified the milestones: 2.82.0, Future Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working cat: mod Category mod (generic) ❓ Feedback Further information is requested P2: High Priority 2
Projects
None yet
Development

No branches or pull requests

5 participants