Incorrect cgame used on Android

[ghost]

Android app seems to always be using cgame from APK, rather than the one from server the client is connecting to. The correct cgame (that is, the one from pak provided by server) is extracted to the app data folder, but the bundled one actually loads.

I tried with latest snapshot (363-g8c26358) and connected TM server, which currently has 66-g337f962 deployed. The APK snapshot version appeared on the loading screen and shortly after entering the game, I was disconnected with Unknown event: 56, which makes sense, given that I have an incompatible cgame loaded.

[rafal1137]

It is issue with overwriting/no properly unpacking cgame ui files.

By Default Android Apk comes with current pk3 file in which is located from AssetManager and copied to the Internal Storage

etlegacy/app/src/main/java/org/etlegacy/app/ETLMain.java

Lines 104 to 115 in 524f1cc

	String etl_pak = new String();
	AssetManager assManager = getApplicationContext().getAssets();
	try {
	for(String file: assManager.list("")) {
	if(file.endsWith(".pk3")) {
	etl_pak += file;
	}
	}
	} catch (IOException e) {
	e.printStackTrace();
	}

etlegacy/app/src/main/java/org/etlegacy/app/ETLMain.java

Lines 130 to 141 in 524f1cc

	final File etl_etlegacy = new File(getExternalFilesDir(null), "etlegacy/legacy/".concat(etl_pak));
	if (!etl_etlegacy.exists()) {
	InputStream is = null;
	try {
	is = assManager.open(etl_pak);
	} catch (IOException e) {
	// TODO Auto-generated catch block
	e.printStackTrace();
	}
	copyInputStreamToFile(is, etl_etlegacy);
	}

Connecting to any Legacy Server that comes with non current version downloads pk3 files into dlcache dir in which those files should be extracted. but they do not.

PS: This one may have something to dowith current Android Restrictions.
We either allow some more access to the internal of etlegacy app or we move into another dir outside of Android/data

[x0rnn]

Yes, move it. I/we can only access Android/data for reading, can't copy any configs or demos there due to unrooted Android protection.

[rafal1137]

So yeah it looks like this Android Restricts everything to the Android/data/etlegacy instead of sdcard/legacy
Need to take a deeper look at it.

[rafal1137]

Just connected to the Hirntot with their more up to date snapshot build and it did worked flaweslly.
It is like older snapshots/releases are not compatible anymore :O

[ghost]

Hirntot runs on a snapshot built yesterday. The problem occurs once qagame and bundled cgame from APK become incompatible enough. It wouldn't work with a snapshot APK against v2.81.1 cgame and vice-versa.

[rafal1137]

Hirntot runs on a snapshot built yesterday. The problem occurs once qagame and bundled cgame from APK become incompatible enough. It wouldn't work with a snapshot APK against v2.81.1 cgame and vice-versa.

Yes they did updated to the latest one. but they in fact had previous one before that in which latest apk snapshot worked fine.

[ghost]

The previous one was fairly recent as well. Anyway, is loading the actual server-provided cgame doable? Using whatever APK is close enough to what the server is running is an option, but only as far as the server runs Legacy mod. If other mods decided to compile for Android, current Legacy client would still try to load the Legacy cgame that came up with it, or at least that's what it does now.

[x0rnn]

This will be a problem for our custom freezetag gamemode we will have as an Xmas event on Hirntot. Requires a custom built mod. Not that we expect any/many Android players but it won't be compatible.