Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of compressed file formats? #34

Closed
ETLegacyTeam opened this issue Mar 5, 2020 · 4 comments
Closed

Adding support of compressed file formats? #34

ETLegacyTeam opened this issue Mar 5, 2020 · 4 comments
Labels
cat: client Category engine (client, renderer, sdl) 💡 Feature New feature or request P3: Normal Priority 3
Milestone

Comments

@ETLegacyTeam
Copy link
Member

ETLegacyTeam commented Mar 5, 2020

Author: @IR4T4 (IR4T4)
Date: 2012-04-30
Redmine Issue: 34, https://dev.etlegacy.com/issues/34


wav files are huuuuge ... implement support of Ogg/Vorbis, Matroska or other free formats ... mp3 might cause trouble because of licence issues.


Child issue(s): #40


Related commit(s):
0596e04 - premake: added option to use OGG Vorbis codec (--w..
26af6ec - game: playsound command from ETPub/NQ refs 34
fad2154 - client: merged and modified S_Play_f function base..
13f1030 - cgame: ET sounds are not compressed refs 34
09acb25 - ui: ET sounds are not compressed refs 34
cbad2b5 - cgame/ui: pass the compressed param for register s..
139b5af - misc: removed readline support from Lua, added OGG..
9af53da - client: ogg vorbis is armed now refs 34
ef15707 - misc: FEATURE OGG VORBIS enabled by default refs ..
e3d315b - cgame: added a warning for non wav sounds refs 34

@ETLegacyTeam ETLegacyTeam added cat: client Category engine (client, renderer, sdl) 💡 Feature New feature or request Fixed P3: Normal Priority 3 labels Mar 5, 2020
@ETLegacyTeam ETLegacyTeam added this to the 2.71rc1 milestone Mar 5, 2020
@ETLegacyTeam
Copy link
Member Author

From: @adanski (Dragonji)
Date: 2012-11-13T15:54:00Z


There are MP3 decoders licensed under GPL:

http://www.underbit.com/products/mad/

http://www.gamedev.net/topic/328904-mp3-decoder/

@ETLegacyTeam
Copy link
Member Author

From: @TheDushan (TheDushan)
Date: 2013-01-14T22:22:16Z


OGG Vorbis is already supported inside ET:Legacy, there is no need to add another dependence library file inside project.

My two cents :)

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2013-01-15T07:54:28Z


{TODO}

  • Test OGG vorbis
sfxHandle_t trap_S_RegisterSound(const char *sample, qboolean compressed)
{
	CG_DrawInformation(qtrue);
	return syscall(CG_S_REGISTERSOUND, sample, qfalse /* compressed */);
}

  • Find a way to use it (Legacy clients only - not 2.60 genuine)
    We can't change the wav sounds from maps, voice chats etc. But we may use ogg vorbis sounds in combination with the playsound cmd.

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2013-01-31T15:26:21Z


Playsound itself has some issues see #186 - but ogg vorbis sounds are available via the /playsound command now.

Aranud pushed a commit that referenced this issue May 6, 2022
GPL source (Steam version) does not work properly with compressed sound formats, so force it off for non-ETL clients like other mods do.
rafal1137 pushed a commit that referenced this issue Sep 13, 2022
GPL source (Steam version) does not work properly with compressed sound formats, so force it off for non-ETL clients like other mods do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: client Category engine (client, renderer, sdl) 💡 Feature New feature or request P3: Normal Priority 3
Projects
None yet
Development

No branches or pull requests

1 participant