Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game: add et_Chat Lua hook #2567

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Exagone313
Copy link
Contributor

@Exagone313 Exagone313 commented May 15, 2024

Adds a Lua hook to be able to edit chat messages effortlessly.

The et_Chat hook name can be modified if wanted.

Let me know if there is documentation to update elsewhere (for example for https://etlegacy-lua-docs.readthedocs.io/).

Documented on etlegacy/etlegacy-lua-docs#1

Relates to etlegacy/etlegacy-lua-scripts#17

@jackeri
Copy link
Member

jackeri commented May 21, 2024

It would maybe be better if the et_Chat by default returned 2 values, a boolean and the modified string. If the boolean is true, then the string is modified?

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarCloud

@Exagone313
Copy link
Contributor Author

It would maybe be better if the et_Chat by default returned 2 values, a boolean and the modified string. If the boolean is true, then the string is modified?

I have made this modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants