game: split EV_BULLET event again #2578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aciz 3rd time's the charm? :3 |
Vorschreibung
force-pushed
the
fix-2570-3rd
branch
2 times, most recently
from
a3e4a46
to
defc928
Compare
|
Rebased on |
The commit d8bba8e tried to unify the 2 separate EV_BULLET_HIT_WALL/EV_BULLET_HIT_FLESH events into just EV_BULLET. This however caused bugs on the client due to an overflow of the `eventParm` field, which was attempted to be repurposed to separate between wall/flesh events. (etlegacy#2571) This commit leaves the majority of code refactoring from d8bba8e and splits EV_BULLET into EV_BULLET_HIT_WALL and EV_BULLET_HIT_FLESH again. fixes etlegacy#2571
Vorschreibung
force-pushed
the
fix-2570-3rd
branch
from
defc928
to
a630dd0
Compare
|
|
i believe this would break demo playback compatibility |
|
Superseded by ac4b2de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit d8bba8e tried to unify the 2 separate EV_BULLET_HIT_WALL/EV_BULLET_HIT_FLESH events into just EV_BULLET.
This however caused bugs on the client due to an overflow of the
eventParmfield, which was attempted to be repurposed to separate between wall/flesh events.(#2571)
This commit leaves the majority of code refactoring from d8bba8e and splits EV_BULLET into EV_BULLET_HIT_WALL and EV_BULLET_HIT_FLESH again.
fixes #2571