cmake: Track etmain dependencies #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vorschreibung
force-pushed
the
cmake-track-etmain
branch
2 times, most recently
from
c0df469
to
dc2c3b1
Compare
Static files packed into 'legacy_*.pk3' were not tracked as dependencies by CMake. This meant that e.g. changing 'etmain/ui/main.menu' would not cause cause a rebuild of the 'legacy_*.pk3' if it has been built prior without rerunning CMake or cleaning the build tree. This was done by globbing twice, one time with 'GLOB_RECURSE' which is used for 'DEPENDS', and once with 'GLOB' which is used for the arguments to 'cmake -E tar'. This is a workaround due to the fact that shelling out to 'cmake -E tar' with the 'GLOB_RECURSE' LIST would provide more arguments than Windows can handle and also due to 'cmake -E tar' not having implemented the '-T'/'--files-from' option that GNU tar provides. 'file(ARCHIVE_CREATE ...)' would require a CMake version bump and further does not seem to work with files outputted by targets.
Vorschreibung
force-pushed
the
cmake-track-etmain
branch
from
dc2c3b1
to
0d8e600
Compare
|
Should work now across all platforms, read to review again 🫶 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static files packed into 'legacy_*.pk3' were not tracked as dependencies
by CMake.
This meant that e.g. changing 'etmain/ui/main.menu' would not cause
cause a rebuild of the 'legacy_*.pk3' if it has been built prior without
rerunning CMake or cleaning the build tree.
This was done by globbing twice, one time with 'GLOB_RECURSE' which is
used for 'DEPENDS', and once with 'GLOB' which is used for the arguments
to 'cmake -E tar'.
This is a workaround due to the fact that shelling out to 'cmake -E tar'
with the 'GLOB_RECURSE' LIST would provide more arguments than Windows
can handle and also due to 'cmake -E tar' not having implemented the
'-T'/'--files-from' option that GNU tar provides.
'file(ARCHIVE_CREATE ...)' would require a CMake version bump and
further does not seem to work with files outputted by targets.