random_spinor_field in index_jd.c

[deuzeman]

As I understand, this function doesn't exist anymore -- it's either random_spinor_field_eo or random_spinor_field_lexic. That leads to two questions:

• I don't know this part of the code and don't really want to spend time on it. Can anyone tell me which one should it be? Elena introduced the function originally in 2010.
• Is this dead code? Because this should be causing errors. If so, how about scrapping it?

I'm running into this, because I want to make sure I'm getting all the memory management right in the implementation of HEX force smearing (prototype done, by the way). There it helps to turn on -Wall -Werror so that sloppiness will actually halt compilation. There's a few spurious warnings / minor coding errors I've had to clear up in other parts of the code, (will backport this), but this one is less trivial.

[kostrzewa]

Hmm, in order to fix this we would need to add a function for random spinor fields of arbitrary size which would be unable to be reproducible. I'm not sure I really understand the point of filling VOLUMEPLUSRAND with random numbers locally (i.e.: without exchanging boundaries).