Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error manager with dynamic values #561

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Error manager with dynamic values #561

merged 3 commits into from
Mar 15, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Mar 12, 2024 •
edited
Loading

Fixes #540 .

Changes proposed in this Pull Request:

  • Add errorOptions and titleOptions using TOptions
  • Update BasicDialog and ErrorMessageBox for options

Screenshots / Screen Recording (if applicable)

image

To Test:

  • clone repo and git checkout feature/blui-5379-error-manager-dynamic-trans
  • yarn start:example
  • click create account
  • accept EULA
  • enter email address
  • click next
  • I will remove test code after review please do not merge

image
image

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Mar 12, 2024
@JeffGreiner-eaton JeffGreiner-eaton marked this pull request as ready for review March 12, 2024 19:20
surajeaton
surajeaton reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting this error after checking out this branch:

Screenshot 2024-03-15 at 6 38 55 PM

surajeaton
surajeaton approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please remove the test code before merging.
Screenshot 2024-03-15 at 6 45 46 PM

@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit ae663ee):

https://blui-react-login--pr561-feature-blui-5379-er-5w1rr2fm.web.app

(expires Sun, 17 Mar 2024 13:41:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

@JeffGreiner-eaton JeffGreiner-eaton merged commit 8b3df17 into dev Mar 15, 2024
7 checks passed
@JeffGreiner-eaton JeffGreiner-eaton deleted the feature/blui-5379-error-manager-dynamic-trans branch March 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajeaton surajeaton surajeaton approved these changes

@ektaghag-eaton ektaghag-eaton Awaiting requested review from ektaghag-eaton ektaghag-eaton is a code owner

@aubreyhthompson aubreyhthompson Awaiting requested review from aubreyhthompson

@manojleaton manojleaton Awaiting requested review from manojleaton

@ArshdeepSingh3-eaton ArshdeepSingh3-eaton Awaiting requested review from ArshdeepSingh3-eaton

Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ErrorManager not allowing to integrate dynamic values into translations.
2 participants
@JeffGreiner-eaton @surajeaton