Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepAR native implementation #114

Merged
merged 30 commits into from Nov 21, 2023
Merged

DeepAR native implementation #114

merged 30 commits into from Nov 21, 2023

Conversation

egoriyaa
Copy link
Collaborator

@egoriyaa egoriyaa commented Oct 16, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #85

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

🚀 Deployed on https://deploy-preview-114--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 16, 2023 13:54 Inactive
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (51e6d92) 89.16% compared to head (94bed72) 89.29%.

Files Patch % Lines
etna/models/nn/deepar_native/loss.py 94.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   89.16%   89.29%   +0.13%     
==========================================
  Files         195      198       +3     
  Lines       12685    12868     +183     
==========================================
+ Hits        11311    11491     +180     
- Misses       1374     1377       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request October 17, 2023 07:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 18, 2023 12:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 18, 2023 15:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 19, 2023 07:27 Inactive
etna/models/base.py Outdated Show resolved Hide resolved
etna/models/base.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request October 24, 2023 13:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 24, 2023 14:35 Inactive
etna/models/nn/__init__.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/__init__.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/loss.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/loss.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/loss.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/sample.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request October 26, 2023 07:23 Inactive
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/sampler.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/loss.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/loss.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/loss.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request October 30, 2023 08:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 6, 2023 22:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 7, 2023 05:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 10, 2023 18:26 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update notebook with nn examples and changelog

etna/models/nn/deepar_new/loss.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_new/deepar.py Outdated Show resolved Hide resolved
tests/test_models/test_nn/deepar/test_loss.py Outdated Show resolved Hide resolved
tests/test_models/test_nn/deepar/test_loss.py Outdated Show resolved Hide resolved
tests/test_models/test_nn/deepar/test_loss.py Outdated Show resolved Hide resolved
tests/test_models/test_nn/deepar/test_loss.py Outdated Show resolved Hide resolved
tests/test_models/test_nn/deepar/test_loss.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request November 18, 2023 10:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 19, 2023 22:51 Inactive
etna/models/nn/deepar_native/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_native/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_native/deepar.py Outdated Show resolved Hide resolved
etna/models/nn/deepar_native/deepar.py Show resolved Hide resolved
tests/test_core/test_to_dict.py Outdated Show resolved Hide resolved
tests/test_models/test_nn/deepar_native/test_loss.py Outdated Show resolved Hide resolved
tests/test_models/test_nn/deepar_native/test_loss.py Outdated Show resolved Hide resolved
tests/test_models/test_nn/deepar_native/test_loss.py Outdated Show resolved Hide resolved
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot temporarily deployed to pull request November 20, 2023 12:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 20, 2023 14:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 20, 2023 15:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 21, 2023 12:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 21, 2023 13:00 Inactive
@alex-hse-repository alex-hse-repository merged commit e68ad36 into master Nov 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeepAR native implementation
2 participants