[BUG] Ensembles works incorrectly with HierarchicalPipeline #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-bunin
requested changes
Dec 6, 2023
| @@ -26,6 +30,66 @@ def direct_ensemble_pipeline() -> DirectEnsemble: | |||
| return ensemble | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def naive_pipeline_top_down_market() -> Pipeline: | |||
There was a problem hiding this comment.
Why do you repeat fixtures here?
There was a problem hiding this comment.
For DirectEnsemble we need fixture with different horizon, rename them slightly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 89.29% 89.29% -0.01%
==========================================
Files 198 198
Lines 12868 12866 -2
==========================================
- Hits 11491 11489 -2
Misses 1377 1377 ☔ View full report in Codecov by Sentry. |
|
🚀 Deployed on https://deploy-preview-177--etna-docs.netlify.app |
d-a-bunin
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #167