Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regressor attribute into sklearn models #199

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

GoshaLetov
Copy link

@GoshaLetov GoshaLetov commented Dec 16, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Added self.regressor in SklearnPerSegmentModel and SklearnMultiSegmentModel

Closing issues

closes #76

@GoshaLetov GoshaLetov changed the title Issue 76 Add self.regressor Dec 16, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a476f0) 89.29% compared to head (515b4f2) 89.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   89.29%   89.29%           
=======================================
  Files         198      198           
  Lines       12866    12868    +2     
=======================================
+ Hits        11489    11491    +2     
  Misses       1377     1377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
etna/models/sklearn.py Show resolved Hide resolved
Copy link
Collaborator

@d-a-bunin d-a-bunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it after all tests pass.

@d-a-bunin d-a-bunin changed the title Add self.regressor Add regressor attribute into sklearn models Dec 20, 2023
@d-a-bunin d-a-bunin merged commit 18f7a5b into etna-team:master Dec 20, 2023
15 checks passed
@GoshaLetov GoshaLetov deleted the issue-76 branch December 20, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Method to_dict doesn't work for SklearnPerSegmentModel and SklearnMultiSegmentModel
2 participants