Add size method to TSDataset class #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-238--etna-docs.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 89.04% 89.05%
=======================================
Files 199 199
Lines 13200 13208 +8
=======================================
+ Hits 11754 11762 +8
Misses 1446 1446 ☔ View full report in Codecov by Sentry. |
|
We should update CHANGELOG.md file. |
ostreech1997
reviewed
Feb 9, 2024
etna/datasets/tsdataset.py
Outdated
| Returns | ||
| ------- | ||
| : | ||
| Number of time series, number of segments, and number of features (if their amounts are equal in each segment; otherwise, returns None) |
There was a problem hiding this comment.
I think, we should write this info before "Returns", something like this:
def size(self) -> Tuple[int, int, Optional[int]]:
"""Return size of TSDataset.
The order of sizes is (number of time series, number of segments,
and number of features (if their amounts are equal in each segment; otherwise, returns None)).
Returns
-------
:
Tuple of TSDataset sizes
"""
CHANGELOG.md
Outdated
| @@ -22,7 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Add dataset integrity check using hash for internal datasets ([#151](https://github.com/etna-team/etna/pull/151)) | |||
| - Create page about internal datasets in documentation ([#175](https://github.com/etna-team/etna/pull/175)) | |||
| - Add usage example of internal datasets in `101-get_started.ipynb` and `305-classification.ipynb` tutorials ([#202](https://github.com/etna-team/etna/pull/202)) | |||
| - | |||
| - The size method has been added to TSDataset in `TSDataset.py`([#238](https://github.com/etna-team/etna/pull/238)) | |||
There was a problem hiding this comment.
I think, that we could rewrite it like this:
Add size method to `TSDataset` class ([#238](https://github.com/etna-team/etna/pull/238))
ostreech1997
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #235