Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing integer timestamp, refactor with timestamp_range #244

Merged
merged 2 commits into from Feb 22, 2024

Conversation

d-a-bunin
Copy link
Collaborator

@d-a-bunin d-a-bunin commented Feb 20, 2024

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  • Add timestamp_range and refactor code
  • Add fixes for some bugs

Closing issues

@d-a-bunin d-a-bunin added this to the Handling unaligned data milestone Feb 20, 2024
@d-a-bunin d-a-bunin self-assigned this Feb 20, 2024
Copy link

github-actions bot commented Feb 20, 2024

🚀 Deployed on https://deploy-preview-244--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 20, 2024 12:07 Inactive
@d-a-bunin d-a-bunin changed the title feature: add timestamp_range, fix bugs Fix indexing, refactor with timestamp_range Feb 20, 2024
@d-a-bunin d-a-bunin changed the title Fix indexing, refactor with timestamp_range Fix indexing integer timestamp, refactor with timestamp_range Feb 20, 2024
@github-actions github-actions bot temporarily deployed to pull request February 20, 2024 12:15 Inactive
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (unaligned-data@7c5aa0e). Click here to learn what that means.

Files Patch % Lines
etna/analysis/eda/plots.py 0.00% 4 Missing ⚠️
etna/analysis/forecast/plots.py 33.33% 2 Missing ⚠️
etna/analysis/decomposition/plots.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             unaligned-data     #244   +/-   ##
=================================================
  Coverage                  ?   90.00%           
=================================================
  Files                     ?      198           
  Lines                     ?    13338           
  Branches                  ?        0           
=================================================
  Hits                      ?    12005           
  Misses                    ?     1333           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_datasets/test_utils.py Show resolved Hide resolved
etna/datasets/tsdataset.py Show resolved Hide resolved
etna/datasets/datasets_generation.py Show resolved Hide resolved
etna/datasets/utils.py Show resolved Hide resolved
etna/transforms/math/differencing.py Show resolved Hide resolved
etna/transforms/math/differencing.py Show resolved Hide resolved
etna/transforms/missing_values/resample.py Show resolved Hide resolved
etna/analysis/eda/plots.py Show resolved Hide resolved
etna/analysis/forecast/plots.py Show resolved Hide resolved
@d-a-bunin d-a-bunin merged commit ed8507a into unaligned-data Feb 22, 2024
16 checks passed
@d-a-bunin d-a-bunin deleted the timestamp-range-fixes branch February 22, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants