New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation with new tutorial about working with misaligned data #288
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
🚀 Deployed on https://deploy-preview-288--etna-docs.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
=======================================
Coverage 89.91% 89.92%
=======================================
Files 200 200
Lines 13968 13971 +3
=======================================
+ Hits 12560 12563 +3
Misses 1408 1408 ☔ View full report in Codecov by Sentry. |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:33Z How this logic matches with inference strategies? d-a-bunin commented on 2024-03-28T11:26:07Z I don't really get what do you mean under inference strategies here, can you elaborate? alex-hse-repository commented on 2024-03-29T05:50:23Z For example we can fit the pipeline on misaligned data and run inference on aligned dataset d-a-bunin commented on 2024-03-29T07:25:16Z It doesn't work that simple. Working with misaligned data is implemented by working with integer timestamp, that's all.
You can fit on data with integer timestamp where some segments are misaligned to others (e.g. they are really old) and later make an inference on subset of segments that you want to forecast.
alex-hse-repository commented on 2024-03-29T08:54:07Z Let's add example for this scenario "pipeline on misaligned data and run inference on aligned dataset" |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:34Z Which combinations of alignment and "regularity" do we support?
d-a-bunin commented on 2024-03-28T11:25:22Z
alex-hse-repository commented on 2024-03-29T05:51:49Z Is it helpful info, how do you think? |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:35Z We need to visualize somehow that series are now misaligned |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:36Z
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:37Z Don't get why do we need d-a-bunin commented on 2024-03-28T11:15:31Z These external timestamps are sitting inside alex-hse-repository commented on 2024-03-29T05:54:15Z Looks like parameter which I always set to 100000 d-a-bunin commented on 2024-03-29T07:25:47Z If you have a lot of memory you are free to go)
|
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:37Z We need highlight the blocks with different utilities, may be add subsections |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:38Z What about model where "we should also pass a parameter |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:39Z Better to add more examples of such transform |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:40Z Line #5. date_flags = DateFlagsTransform( May be separate this transform from others to highlight that we set the |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:40Z What about forecasting? I want to forecast misaligned time series and get forecasts with original index, how can I do it? Can we plot forecasts in original index? d-a-bunin commented on 2024-03-28T11:22:19Z You are forecasting the values with integer index, original index is just a feature. If you have this feature in your forecast you know which value correspond to which timestamp. If you don't have this feature in your forecast you could use make_timestamp_df_from_alignment to recreate it, I think. I haven't really thought about this problem. Do you have any ideas how should it work for the user?
No, currently we can't draw forecasts with original timestamps. alex-hse-repository commented on 2024-03-29T05:57:41Z
d-a-bunin commented on 2024-03-29T07:28:04Z Let's assume we have a data there some segments are really old and doesn't have to be forecasted anymore. We can align them with new segments and fit our pipeline. After that we can use that pipeline to forecast only recent segments that we are working with. In that scenario we were able to use the patterns that we learnt from old segments. |
View / edit / reply to this conversation on ReviewNB alex-hse-repository commented on 2024-03-28T10:17:41Z May be we can add an example here? |
These external timestamps are sitting inside View entire conversation on ReviewNB |
You are forecasting the values with integer index, original index is just a feature. If you have this feature in your forecast you know which value correspond to which timestamp. If you don't have this feature in your forecast you could use make_timestamp_df_from_alignment to recreate it, I think. I haven't really thought about this problem. Do you have any ideas how should it work for the user?
No, currently we can't draw forecasts with original timestamps. View entire conversation on ReviewNB |
View entire conversation on ReviewNB |
I don't really get what do you mean under inference strategies here, can you elaborate? View entire conversation on ReviewNB |
For example we can fit the pipeline on misaligned data and run inference on aligned dataset View entire conversation on ReviewNB |
Is it helpful info, how do you think? View entire conversation on ReviewNB |
Looks like parameter which I always set to 100000 View entire conversation on ReviewNB |
View entire conversation on ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
It doesn't work that simple. Working with misaligned data is implemented by working with integer timestamp, that's all.
You can fit on data with integer timestamp where some segments are misaligned to others (e.g. they are really old) and later make an inference on subset of segments that you want to forecast.
View entire conversation on ReviewNB |
If you have a lot of memory you are free to go)
View entire conversation on ReviewNB |
Let's assume we have a data there some segments are really old and doesn't have to be forecasted anymore. We can align them with new segments and fit our pipeline. After that we can use that pipeline to forecast only recent segments that we are working with. In that scenario we were able to use the patterns that we learnt from old segments. View entire conversation on ReviewNB |
Let's add example for this scenario "pipeline on misaligned data and run inference on aligned dataset" View entire conversation on ReviewNB |
Before submitting (must do checklist)
Proposed Changes
Look #277.
Closing issues
Closes #277.