Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TSTCC #294

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Implement TSTCC #294

merged 10 commits into from
Apr 10, 2024

Conversation

egoriyaa
Copy link
Collaborator

@egoriyaa egoriyaa commented Apr 3, 2024

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #284

@egoriyaa egoriyaa changed the title add tstcc Implement TSTCC Apr 3, 2024
@egoriyaa egoriyaa self-assigned this Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

🚀 Deployed on https://deploy-preview-294--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 12:23 Inactive
@egoriyaa egoriyaa requested review from Ama16 and d-a-bunin April 3, 2024 12:39
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 97.52066% with 9 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (embeddings@7761884). Click here to learn what that means.

❗ Current head 18defeb differs from pull request most recent head bef65aa. Consider uploading reports for the commit bef65aa to get more accurate results

Files Patch % Lines
etna/libs/tstcc/attention.py 93.15% 5 Missing ⚠️
etna/libs/tstcc/loss.py 93.02% 3 Missing ⚠️
etna/libs/tstcc/augmentations.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             embeddings     #294   +/-   ##
=============================================
  Coverage              ?   87.77%           
=============================================
  Files                 ?      220           
  Lines                 ?    14176           
  Branches              ?        0           
=============================================
  Hits                  ?    12443           
  Misses                ?     1733           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request April 3, 2024 13:29 Inactive
docs/source/api_reference/transforms.rst Show resolved Hide resolved
etna/libs/tstcc/augmentations.py Show resolved Hide resolved
etna/libs/tstcc/tstcc.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request April 8, 2024 09:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 8, 2024 13:11 Inactive
@egoriyaa egoriyaa requested a review from d-a-bunin April 9, 2024 04:05
Copy link
Collaborator

@d-a-bunin d-a-bunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changelog?

@github-actions github-actions bot temporarily deployed to pull request April 9, 2024 07:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 9, 2024 10:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 9, 2024 11:39 Inactive
@egoriyaa egoriyaa requested a review from d-a-bunin April 9, 2024 12:59
@egoriyaa egoriyaa merged commit 2b0b4c5 into embeddings Apr 10, 2024
14 checks passed
egoriyaa added a commit that referenced this pull request May 3, 2024
* Implement TS2VecModel (#253)

* add ts2vec model

* delete unnecessary utils

* add multiscale mode

* revert to common encode in model class

* lints

* reformat save method, add _is_fitted attr

* fix embeddings shapes

* fix

* one more fix

* pass numpy array to fit

* add tests checking nans in embeddings

* update changelog

---------

Co-authored-by: Egor Baturin <egoriyaa@github.com>

* Implement EmbeddingSegmentTransform and EmbeddingWindowTransform (#265)

* add transforms

* update changelog

* fix ts2vec tests

* fix

* update rst, encoding_params

* fix

* fix

* fix

* fix docstring

* add training_params

* add freeze method

* fix inference tests

* lints

* fix lisence

* fix lisence, fix docs

* fix quotes

---------

Co-authored-by: Egor Baturin <egoriyaa@github.com>

* Implement TSTCC (#294)

* add tstcc

* add einops package

* remove pd.testing in inference tests

* fix

* add verbose param, refactor logging, fix warning

* fix logging loss

* add changelog

* catch torch warning

* fix

* catch nn.Conv1d warning

---------

Co-authored-by: Egor Baturin <egoriyaa@github.com>

* lints

* fix

* Add tutorial how to work with embedding models (#304)

* fix tstcc

* move lr param from __init__ to fit

* add tutorial

* fix notebook

* update changelog

* fix changelog

* lints

* fix notebook

* update readme

* fix readme

* fix readme

* write comment in libs/ts2vec/ts2vec.py

* fix notebook

* remove multiscale option in ts2vec

* lints

* fix notebook

---------

Co-authored-by: Egor Baturin <egoriyaa@github.com>

* fix atol in inference tests

* downgrade poetry

---------

Co-authored-by: Egor Baturin <egoriyaa@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants