fix ResampleWithDistributionTransform with holidays transform #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 89.11% 89.23% +0.12%
==========================================
Files 194 205 +11
Lines 12491 12807 +316
==========================================
+ Hits 11131 11428 +297
- Misses 1360 1379 +19
☔ View full report in Codecov by Sentry. |
|
🚀 Deployed on https://deploy-preview-82--etna-docs.netlify.app |
alex-hse-repository
requested changes
Sep 12, 2023
alex-hse-repository
requested changes
Sep 13, 2023
| @@ -132,3 +136,16 @@ def test_get_regressors_info_not_fitted(): | |||
| def test_params_to_tune(): | |||
| transform = ResampleWithDistributionTransform(in_column="regressor_exog", distribution_column="target") | |||
| assert len(transform.params_to_tune()) == 0 | |||
|
|
|||
|
|
|||
| def test_working_with_categorical_columns(example_tsds): | |||
There was a problem hiding this comment.
Not sure that we need pipeline here, we just want to check that fit_transform works with categoricals. Try to be more minimalistic
alex-hse-repository
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #34