Fix bug converting array type #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
Jun 8, 2022
| @@ -289,7 +289,9 @@ def _convert_col(self, col: pd.Series, field_type) -> pd.Series: | |||
| return col.apply(partial(_convert_udt_value, udt=udt)) | |||
| elif field_type["type"] == "struct": | |||
| return col.apply(lambda d: self._convert(d, field_type)) | |||
| elif field_type["type"] == "array": | |||
| elif field_type["type"] == "array" and isinstance( | |||
There was a problem hiding this comment.
is there possible other case like type == array and not isinstance(elementType, dict)?
eddyxu
reviewed
Jun 8, 2022
| @@ -289,7 +289,9 @@ def _convert_col(self, col: pd.Series, field_type) -> pd.Series: | |||
| return col.apply(partial(_convert_udt_value, udt=udt)) | |||
| elif field_type["type"] == "struct": | |||
| return col.apply(lambda d: self._convert(d, field_type)) | |||
| elif field_type["type"] == "array": | |||
| elif field_type["type"] == "array" and isinstance( | |||
There was a problem hiding this comment.
is there possible other case like type == array and not isinstance(elementType, dict)?
There was a problem hiding this comment.
if the elementType is not a dict then it's a simple native type which requires no conversion so it should go to the "else"
eddyxu
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.