allow custom sorting of toHierarchy result #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 4, 2014 14:04
allow custom sorting of toHierarchy result, using a arbitrary comparator function with uasort. Fixes #41. Possibly not as efficient as a pure SQL solution depending on the complexity of the sort and the number or records but for simple comparison its fairly elegant. example to sort by "name" attribute of node ``` $sorted = Category::all()->toHierarchy(function($a,$b){ return strcmp($a->name, $b->name);}) ```
set children relation to empty array for leaf nodes to prevent them from being re-queried when iterating over tree in template or such.
tests expect a collection object as they use its count function so return an empty collection rather than an empty array.
ghost
mentioned this pull request
Closed
|
This fixes an issue I have in #45; I'll vote for its inclusion. |
|
There's now a way to implement custom sorting in the library. Will that suffice? I think it's rather preferable to get the results collection sorted from the database (which is faster) than sorting it client-side. |
|
I'm sorry but the Also, now it is possible for you to use the provided sort operations on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow custom sorting of toHierarchy result, using a arbitrary comparator
function with uasort. Fixes #41.
Possibly not as efficient as a pure SQL solution depending on the
complexity of the sort and the number or records but for simple
comparison its fairly elegant.
example to sort by "name" attribute of node