Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Closing to detect dependent resources #636

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Conversation

StummeJ
Copy link
Contributor

@StummeJ StummeJ commented Nov 15, 2022

This attempts to fix Issue #633 by detecting providers.Resource that are dependencies of other injected dependencies.

@rmk135 rmk135 changed the base branch from master to develop December 19, 2022 02:45
@rmk135 rmk135 self-requested a review December 19, 2022 02:45
@rmk135 rmk135 self-assigned this Dec 19, 2022
@rmk135 rmk135 merged commit 3b76a0d into ets-labs:develop Dec 19, 2022
@rmk135
Copy link
Member

rmk135 commented Dec 19, 2022

@StummeJ Amazing! Thanks a lot for the contribution!

federinik added a commit to federinik/python-dependency-injector that referenced this pull request Dec 21, 2022
jazzthief added a commit to GodelTech/python-dependency-injector that referenced this pull request May 23, 2023
Allow Closing to detect dependent resources passed as kwargs too ets-labs#636
arianamiri pushed a commit to arianamiri/python-dependency-injector that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants