-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test script fails to parse tag(0) date strings correctly. #213
Labels
general
A general issue with test data, such as with the data provided in the /common folder.
Comments
dirkx
added
the
general
A general issue with test data, such as with the data provided in the /common folder.
label
May 26, 2021
dirkx
changed the title
test script
test script fails to parse tag(0) date strings correctly.
May 26, 2021
@bhavin-qryptal Can you please add the tag 0 support for date time values? |
daniel-eder
added a commit
that referenced
this issue
May 26, 2021
Mark findings related to #213 as known until test script recognizes them as OK
In hand.
…On Wed, 26 May 2021 at 17:47, SchulzeStTSI ***@***.***> wrote:
@bhavin-qryptal <https://github.com/bhavin-qryptal> Can you please add
the tag 0 support for date time values?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#213 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUDF3WFHOTC43D5PS7JN3C3TPS7T7ANCNFSM45RRM5SQ>
.
|
bhavin-qryptal
added a commit
to bhavin-qryptal/dgc-testdata
that referenced
this issue
May 26, 2021
…than spec and Updated Known Issue List
@SchulzeStTSI and @daniel-eder , This could be verified and closed. |
daniel-eder
pushed a commit
that referenced
this issue
May 26, 2021
…ssue List (#224) * Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for #213 -> test script is stricter than spec and Updated Known Issue List
daniel-eder
added a commit
that referenced
this issue
Jun 2, 2021
… allowed (#261) * Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for #213 -> test script is stricter than spec and Updated Known Issue List * Updated Known Issue List * Enhanced Test Coverage for SI and LV Test Dataset * Revert test code changes for LV and SI * Updated Known Issue List * Update known_issues.csv * Update known_issues.csv * Only one type of certificate with one entry is allowed. Ref #161 Co-authored-by: Daniel Eder <danieleder@outlook.at>
SchulzeStTSI
pushed a commit
that referenced
this issue
Jun 3, 2021
* Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for #213 -> test script is stricter than spec and Updated Known Issue List * Updated Known Issue List * Enhanced Test Coverage for SI and LV Test Dataset * Revert test code changes for LV and SI * Updated Known Issue List * Update known_issues.csv * Update known_issues.csv * Only one type of certificate with one entry is allowed. Ref #161 * Update known issues list Co-authored-by: Daniel Eder <danieleder@outlook.at>
daniel-eder
added a commit
that referenced
this issue
Jun 10, 2021
* Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for #213 -> test script is stricter than spec and Updated Known Issue List * Updated Known Issue List * Enhanced Test Coverage for SI and LV Test Dataset * Revert test code changes for LV and SI * Updated Known Issue List * Update known_issues.csv * Update known_issues.csv * Only one type of certificate with one entry is allowed. Ref #161 * Update known issues list * Update known issues list Co-authored-by: Daniel Eder <danieleder@outlook.at>
daniel-eder
added a commit
that referenced
this issue
Jun 15, 2021
* Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for #213 -> test script is stricter than spec and Updated Known Issue List * Updated Known Issue List * Enhanced Test Coverage for SI and LV Test Dataset * Revert test code changes for LV and SI * Updated Known Issue List * Update known_issues.csv * Update known_issues.csv * Only one type of certificate with one entry is allowed. Ref #161 * Update known issues list * Update known issues list * Handle datetime with and without fraction for comparison Co-authored-by: Daniel Eder <danieleder@outlook.at>
daniel-eder
added a commit
that referenced
this issue
Jun 28, 2021
…version 1.3 and updated known_issues.csv (#358) * Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for #213 -> test script is stricter than spec and Updated Known Issue List * Updated Known Issue List * Enhanced Test Coverage for SI and LV Test Dataset * Revert test code changes for LV and SI * Updated Known Issue List * Update known_issues.csv * Update known_issues.csv * Only one type of certificate with one entry is allowed. Ref #161 * Update known issues list * Update known issues list * Handle datetime with and without fraction for comparison * Handle datetime with and without fraction for comparison. Use schema version 1.3 and updated known_issues.csv Co-authored-by: Daniel Eder <danieleder@outlook.at>
daniel-eder
added a commit
that referenced
this issue
Jun 28, 2021
* Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for #213 -> test script is stricter than spec and Updated Known Issue List * Updated Known Issue List * Enhanced Test Coverage for SI and LV Test Dataset * Revert test code changes for LV and SI * Updated Known Issue List * Update known_issues.csv * Update known_issues.csv * Only one type of certificate with one entry is allowed. Ref #161 * Update known issues list * Update known issues list * Handle datetime with and without fraction for comparison * Handle datetime with and without fraction for comparison. Use schema version 1.3 and updated known_issues.csv * Support multiple schema versions for validation. * Updated known issue list Co-authored-by: Daniel Eder <danieleder@outlook.at>
daniel-eder
added a commit
that referenced
this issue
Aug 26, 2021
* Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for #213 -> test script is stricter than spec and Updated Known Issue List * Updated Known Issue List * Enhanced Test Coverage for SI and LV Test Dataset * Revert test code changes for LV and SI * Updated Known Issue List * Update known_issues.csv * Update known_issues.csv * Only one type of certificate with one entry is allowed. Ref #161 * Update known issues list * Update known issues list * Handle datetime with and without fraction for comparison * Handle datetime with and without fraction for comparison. Use schema version 1.3 and updated known_issues.csv * Support multiple schema versions for validation. * Updated known issue list * Change default schema URL to version 1.3.0 Co-authored-by: Daniel Eder <danieleder@outlook.at>
zawmyolatt
added a commit
to Notarise-gov-sg/dgc-testdata
that referenced
this issue
Aug 26, 2021
commit 13e33a0 Author: Jože Mlakar <joze.mlakar@ixtlan-team.si> Date: Thu Aug 26 10:25:17 2021 +0200 SI: following valuesets appropriately (eu-digital-green-certificates#365) * First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java * Revert "First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java" This reverts commit a229148. * Slovenian test cases made with https://github.com/ixtlan-team/dgc-java * Sample files from Slovenia using ACC DSC (eu-digital-green-certificates#77) This commit updates samples from Slovenia. Much has changed: - The samples are now signed using DSC from ACC environment. - At the moment DSC is not yet available in ACC as we are waiting for the EC team to complete the inclusion of our NB certs - DSC is created as recommended on onboarding documents (EC) - DGCs are created usign dgc-java project that Slovenia is using for our implementation * Fixing standardized names (eu-digital-green-certificates#220) * Fixing standardized names (eu-digital-green-certificates#220) * Update 1.json * New vac samples and added test and rec samples. All signed with DSC from ACC. * Fixing the incorrenct DSC used for previous commit * Samples changed after dgc-java modified * Fixing number of digits in fractions to 6 * SI: All new codes now issued by NB - ACC * Added EXPECTEDRESULTS array for validation * SI: following valuesets appropriately * SI: following valuesets appropriately * SI: following valuesets appropriately * SI: following valuesets appropriately Co-authored-by: Jože Mlakar <JozeM@ixtlan-team.si> commit 4ec6d5e Author: Bhavin Sanghvi <84303320+bhavin-qryptal@users.noreply.github.com> Date: Thu Aug 26 15:59:45 2021 +0800 To fix failing tests - Change default schema URL to version 1.3.0 (eu-digital-green-certificates#392) * Updated known Issue List * Updated known issue listing * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List. * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Update dgc-testdata-verification.yml * Update dgc-testdata-verification.yml * Update requirements.txt * Enhanced error handling and reporting for test_picture_decode * Fix for eu-digital-green-certificates#213 -> test script is stricter than spec and Updated Known Issue List * Updated Known Issue List * Enhanced Test Coverage for SI and LV Test Dataset * Revert test code changes for LV and SI * Updated Known Issue List * Update known_issues.csv * Update known_issues.csv * Only one type of certificate with one entry is allowed. Ref eu-digital-green-certificates#161 * Update known issues list * Update known issues list * Handle datetime with and without fraction for comparison * Handle datetime with and without fraction for comparison. Use schema version 1.3 and updated known_issues.csv * Support multiple schema versions for validation. * Updated known issue list * Change default schema URL to version 1.3.0 Co-authored-by: Daniel Eder <danieleder@outlook.at> commit d142b8d Author: Mathias Wegmüller <83816011+mathias-wegmueller-ti8m@users.noreply.github.com> Date: Thu Aug 19 17:17:51 2021 +0200 CH: Update test data for Switzerland. (eu-digital-green-certificates#389) * CH - Added initial test data for Switzerland. * CH - Updated test data for Switzerland (SCHEMA 1.2.1). * CH - Fixed value of optional claim iss (key 1) for Switzerland. * CH - Added new test data for Switzerland created with current release 1.1. * CH - Added new test data for Switzerland created with current release 1.2. * CH - Added new test data for Switzerland created with current release 2.0. * CH: Update test data for Switzerland. Co-authored-by: Mathias Wegmüller <matthias.wegmueller@bit.admin.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
general
A general issue with test data, such as with the data provided in the /common folder.
Issue Description
Test scripts appear to not deal correctly with a properly tagged (0) time string (https://datatracker.ietf.org/doc/html/rfc8949#section-3.4.1) according to RFC7049 (https://datatracker.ietf.org/doc/html/rfc7049#section-2.4) table 3 - "Value for Tags".
E.g. passing a QR with
where XX is sc, dr, etc seems to fail.
Proposed Solution
Fix the test to be RFC 8949 compliant. Specifically it is this comparison:
E - '2021-05-25T11:21:51.145008Z'),
E + datetime.datetime(2021, 5, 25, 11, 21, 51, 145008, tzinfo=datetime.timezone.utc)),
Where the failed needs to either not convert the latter string to a datetime or convert the first string to a date time. I guess the most pragmatic thing would be to add to the loads() function flags similar as to the dumps() functions for controlling datetime conversion explictly.
The text was updated successfully, but these errors were encountered: