Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SI: Schema validation failed #220

Closed
daniel-eder opened this issue May 26, 2021 · 5 comments
Closed

SI: Schema validation failed #220

daniel-eder opened this issue May 26, 2021 · 5 comments
Labels
member state data issue

Comments

@daniel-eder
Copy link
Member

Affected Country: SI

Issue Description

#216 fixed #77, but introduced schema validation issues in the json files 1-6 in the standardized family name field, see https://github.com/eu-digital-green-certificates/dgc-testdata/runs/2675618736?check_suite_focus=true
This was referenced May 26, 2021
Open
Merged
daniel-eder added a commit that referenced this issue May 26, 2021
@daniel-eder
Update known_issues.csv
e1b8765 
Add #220, introduced by #216
@jozemlakar
Copy link
Contributor

@daniel-eder can you point me to a spec that says all names should be simplifed ie. all special characters should be removed? We saw the test and was not quite sure if the test is off or our implementation. That is the exact reason we chose the samples the way we did.

@daniel-eder
Copy link
Member Author

@jozemlakar 1.0.0 of the json schema provides the following regex https://github.com/eu-digital-green-certificates/ehn-dgc-schema/blob/02bf437b1f2efe80982e3172a85a757e549b3c64/DGC.combined-schema.json#L95

Note that this field is the standardized family name, for the original name you can use https://github.com/eu-digital-green-certificates/ehn-dgc-schema/blob/02bf437b1f2efe80982e3172a85a757e549b3c64/DGC.combined-schema.json#L86

Hope that clears it up!

@jozemlakar
Copy link
Contributor

Much clearer, will fix ASAP.

jozemlakar added a commit to ixtlan-team/dgc-testdata that referenced this issue May 26, 2021
@jozemlakar
Fixing standardized names (eu-digital-green-certificates#220)
2b9ffa6
@jozemlakar
Copy link
Contributor

Added PR #222

@daniel-eder daniel-eder mentioned this issue May 26, 2021
Merged
jozemlakar added a commit to ixtlan-team/dgc-testdata that referenced this issue May 26, 2021
@jozemlakar
Fixing standardized names (eu-digital-green-certificates#220)
c91117a
daniel-eder pushed a commit that referenced this issue May 26, 2021
@jozemlakar
Fixing standardized names (#220) (#222)
b643f81 
* First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java

* Revert "First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java"

This reverts commit a229148.

* Slovenian test cases made with https://github.com/ixtlan-team/dgc-java

* Sample files from Slovenia using ACC DSC (#77)

This commit updates samples from Slovenia. Much has changed:
- The samples are now signed using DSC from ACC environment.
- At the moment DSC is not yet available in ACC as we are waiting for the EC team to complete the inclusion of our NB certs
- DSC is created as recommended on onboarding documents (EC)
- DGCs are created usign dgc-java project that Slovenia is using for our implementation

* Fixing standardized names (#220)

* Fixing standardized names (#220)

* Update 1.json

Co-authored-by: Jože Mlakar <JozeM@ixtlan-team.si>
@daniel-eder
Copy link
Member Author

Closed in #222

@jozemlakar jozemlakar mentioned this issue May 27, 2021
Open
SchulzeStTSI pushed a commit that referenced this issue Jun 8, 2021
@jozemlakar
SI: Adding test and recovery samples and changing vac samples to one …
522a61f 
…entry (#281)

* First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java

* Revert "First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java"

This reverts commit a229148.

* Slovenian test cases made with https://github.com/ixtlan-team/dgc-java

* Sample files from Slovenia using ACC DSC (#77)

This commit updates samples from Slovenia. Much has changed:
- The samples are now signed using DSC from ACC environment.
- At the moment DSC is not yet available in ACC as we are waiting for the EC team to complete the inclusion of our NB certs
- DSC is created as recommended on onboarding documents (EC)
- DGCs are created usign dgc-java project that Slovenia is using for our implementation

* Fixing standardized names (#220)

* Fixing standardized names (#220)

* Update 1.json

* New vac samples and added test and rec samples. All signed with DSC from ACC.

* Fixing the incorrenct DSC used for previous commit

* Samples changed after dgc-java modified

* Fixing number of digits in  fractions to 6

Co-authored-by: Jože Mlakar <JozeM@ixtlan-team.si>
daniel-eder pushed a commit that referenced this issue Jun 28, 2021
@jozemlakar
SI: All new codes schema 1.3.0 from NB (ACC) (#353)
fb752c9 
* First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java

* Revert "First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java"

This reverts commit a229148.

* Slovenian test cases made with https://github.com/ixtlan-team/dgc-java

* Sample files from Slovenia using ACC DSC (#77)

This commit updates samples from Slovenia. Much has changed:
- The samples are now signed using DSC from ACC environment.
- At the moment DSC is not yet available in ACC as we are waiting for the EC team to complete the inclusion of our NB certs
- DSC is created as recommended on onboarding documents (EC)
- DGCs are created usign dgc-java project that Slovenia is using for our implementation

* Fixing standardized names (#220)

* Fixing standardized names (#220)

* Update 1.json

* New vac samples and added test and rec samples. All signed with DSC from ACC.

* Fixing the incorrenct DSC used for previous commit

* Samples changed after dgc-java modified

* Fixing number of digits in  fractions to 6

* SI: All new codes now issued by NB - ACC

* Added EXPECTEDRESULTS array for validation

Co-authored-by: Jože Mlakar <JozeM@ixtlan-team.si>
daniel-eder pushed a commit that referenced this issue Aug 26, 2021
@jozemlakar
SI: following valuesets appropriately (#365)
13e33a0 
* First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java

* Revert "First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java"

This reverts commit a229148.

* Slovenian test cases made with https://github.com/ixtlan-team/dgc-java

* Sample files from Slovenia using ACC DSC (#77)

This commit updates samples from Slovenia. Much has changed:
- The samples are now signed using DSC from ACC environment.
- At the moment DSC is not yet available in ACC as we are waiting for the EC team to complete the inclusion of our NB certs
- DSC is created as recommended on onboarding documents (EC)
- DGCs are created usign dgc-java project that Slovenia is using for our implementation

* Fixing standardized names (#220)

* Fixing standardized names (#220)

* Update 1.json

* New vac samples and added test and rec samples. All signed with DSC from ACC.

* Fixing the incorrenct DSC used for previous commit

* Samples changed after dgc-java modified

* Fixing number of digits in  fractions to 6

* SI: All new codes now issued by NB - ACC

* Added EXPECTEDRESULTS array for validation

* SI: following valuesets appropriately

* SI: following valuesets appropriately

* SI: following valuesets appropriately

* SI: following valuesets appropriately

Co-authored-by: Jože Mlakar <JozeM@ixtlan-team.si>
zawmyolatt added a commit to Notarise-gov-sg/dgc-testdata that referenced this issue Aug 26, 2021
@zawmyolatt
Squashed commit of the following:
1be98a8 
commit 13e33a0
Author: Jože Mlakar <joze.mlakar@ixtlan-team.si>
Date:   Thu Aug 26 10:25:17 2021 +0200

    SI: following valuesets appropriately (eu-digital-green-certificates#365)

    * First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java

    * Revert "First samples using https://github.com/ixtlan-team/dgc-java based on https://github.com/DIGGSweden/dgc-java"

    This reverts commit a229148.

    * Slovenian test cases made with https://github.com/ixtlan-team/dgc-java

    * Sample files from Slovenia using ACC DSC (eu-digital-green-certificates#77)

    This commit updates samples from Slovenia. Much has changed:
    - The samples are now signed using DSC from ACC environment.
    - At the moment DSC is not yet available in ACC as we are waiting for the EC team to complete the inclusion of our NB certs
    - DSC is created as recommended on onboarding documents (EC)
    - DGCs are created usign dgc-java project that Slovenia is using for our implementation

    * Fixing standardized names (eu-digital-green-certificates#220)

    * Fixing standardized names (eu-digital-green-certificates#220)

    * Update 1.json

    * New vac samples and added test and rec samples. All signed with DSC from ACC.

    * Fixing the incorrenct DSC used for previous commit

    * Samples changed after dgc-java modified

    * Fixing number of digits in  fractions to 6

    * SI: All new codes now issued by NB - ACC

    * Added EXPECTEDRESULTS array for validation

    * SI: following valuesets appropriately

    * SI: following valuesets appropriately

    * SI: following valuesets appropriately

    * SI: following valuesets appropriately

    Co-authored-by: Jože Mlakar <JozeM@ixtlan-team.si>

commit 4ec6d5e
Author: Bhavin Sanghvi <84303320+bhavin-qryptal@users.noreply.github.com>
Date:   Thu Aug 26 15:59:45 2021 +0800

    To fix failing tests - Change default schema URL to version 1.3.0 (eu-digital-green-certificates#392)

    * Updated known Issue List

    * Updated known issue listing

    * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List.

    * Enhanced Error Handling Capability to be able to flag invalid JSON files as knwon failures and updated Known Issue List.

    * Update dgc-testdata-verification.yml

    * Update dgc-testdata-verification.yml

    * Update dgc-testdata-verification.yml

    * Update dgc-testdata-verification.yml

    * Update requirements.txt

    * Update dgc-testdata-verification.yml

    * Update dgc-testdata-verification.yml

    * Update requirements.txt

    * Enhanced error handling and reporting for test_picture_decode

    * Fix for eu-digital-green-certificates#213 -> test script is stricter than spec and Updated Known Issue List

    * Updated Known Issue List

    * Enhanced Test Coverage for SI and LV Test Dataset

    * Revert test code changes for LV and SI

    * Updated Known Issue List

    * Update known_issues.csv

    * Update known_issues.csv

    * Only one type of certificate with one entry is allowed. Ref eu-digital-green-certificates#161

    * Update known issues list

    * Update known issues list

    * Handle datetime with and without fraction for comparison

    * Handle datetime with and without fraction for comparison. Use schema version 1.3 and updated known_issues.csv

    * Support multiple schema versions for validation.

    * Updated known issue list

    * Change default schema URL to version 1.3.0

    Co-authored-by: Daniel Eder <danieleder@outlook.at>

commit d142b8d
Author: Mathias Wegmüller <83816011+mathias-wegmueller-ti8m@users.noreply.github.com>
Date:   Thu Aug 19 17:17:51 2021 +0200

    CH: Update test data for Switzerland. (eu-digital-green-certificates#389)

    * CH - Added initial test data for Switzerland.

    * CH - Updated test data for Switzerland (SCHEMA 1.2.1).

    * CH - Fixed value of optional claim iss (key 1) for Switzerland.

    * CH - Added new test data for Switzerland created with current release 1.1.

    * CH - Added new test data for Switzerland created with current release 1.2.

    * CH - Added new test data for Switzerland created with current release 2.0.

    * CH: Update test data for Switzerland.

    Co-authored-by: Mathias Wegmüller <matthias.wegmueller@bit.admin.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
member state data issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniel-eder @jozemlakar