Fixing standardized names (#220) #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on https://github.com/DIGGSweden/dgc-java" This reverts commit a229148.
…es#77) This commit updates samples from Slovenia. Much has changed: - The samples are now signed using DSC from ACC environment. - At the moment DSC is not yet available in ACC as we are waiting for the EC team to complete the inclusion of our NB certs - DSC is created as recommended on onboarding documents (EC) - DGCs are created usign dgc-java project that Slovenia is using for our implementation
…es/dgc-testdata into eu-digital-green-certificates-main
daniel-eder
previously approved these changes
May 26, 2021
daniel-eder
dismissed
their stale review
seems files still xfail -> should be xpass, need to verify further
|
@jozemlakar I did not look into it further yet, but it seems the files still fail (albeit now xfail because #220 is marked as known issue). Can you look at the test result html linked in the (passed due to xfail) data verification? If you need further assistance please ping and I'll review as well |
|
We made a mistake while merging. Should be fixed now. |
|
@daniel-eder from what we see in the logs, this should be good. No more XFailed on our samples. |
daniel-eder
approved these changes
May 26, 2021
|
@jozemlakar many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.0 of the json schema provides the following regex https://github.com/eu-digital-green-certificates/ehn-dgc-schema/blob/02bf437b1f2efe80982e3172a85a757e549b3c64/DGC.combined-schema.json#L95
Note that this field is the standardized family name, for the original name you can use https://github.com/eu-digital-green-certificates/ehn-dgc-schema/blob/02bf437b1f2efe80982e3172a85a757e549b3c64/DGC.combined-schema.json#L86