SI: Adding test and recovery samples and changing vac samples to one entry #281
Conversation
…ased on https://github.com/DIGGSweden/dgc-java" This reverts commit a229148.
…es#77) This commit updates samples from Slovenia. Much has changed: - The samples are now signed using DSC from ACC environment. - At the moment DSC is not yet available in ACC as we are waiting for the EC team to complete the inclusion of our NB certs - DSC is created as recommended on onboarding documents (EC) - DGCs are created usign dgc-java project that Slovenia is using for our implementation
…es/dgc-testdata into eu-digital-green-certificates-main
|
Hm, weird errors. As if it was not possible to get files from GitHub. |
There was a problem hiding this comment.
@jozemlakar In file 5 is the prefix not able to decode here: https://github.pathcheck.org/debug.html can you check that?
|
@jozemlakar due to a change in how the EHNs JSON schema URL works, the check for your PR currently fails. Could you update your branch to the latest main to incorporate the updated and working schema URL (specifically, the test script with said updated url)? Then we can see if there are any actual issues left. Thanks! |
|
@daniel-eder we have merged the main and that fixed the URL error. However now we have a problem with sc field (too large of precision in sc field). Will have to wait on Monday. |
jozemlakar
changed the title
|
Failure is due to diggsweden/dgc-java#66 |
|
@daniel-eder @SchulzeStTSI Why is a fine grained time a problem? It is unnecessary, yes, but still. By washing away these odd cases from the test files you actually give validators less data to parse. In my meaning, this shouldn't be an error. |
|
@martin-lindstrom while I would agree, there is also the issue of validation apps that are failing on this. So if we say, we allow fine grained time, then we are also braking verifier apps. One of those "we are right, but at what price" things. |
One could argue that those validator apps should be interested in fixing the problem on their side instead of attempting to get all issuers to limit what is created... |
|
@daniel-eder @SchulzeStTSI About date-time... From the specification: The date and time when the test sample was collected. The time MUST include information on the time zone. The value MUST NOT denote the time when the test result was produced. Exactly 1 (one) non-empty field MUST be provided. One of the following ISO 8601 formats MUST be used. Other options are not supported. Examples: I heard from @jozemlakar that you expect fractions and don't accept the above? Is that correct? If so, the test scripts need to be updated. |
|
@daniel-eder @SchulzeStTSI @martin-lindstrom this is base on failed checks when I submitted samples without fractions. Checks failed because expected value was |
No description provided.