Allow quote & space characters to be configured #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this will be useful! I have a couple questions, though:
|
|
Good call on both counts.. un momento |
Also rename spaceChar to spaceCharacter to match the other naming
| // Here we go, backslash escaping | ||
| // As a special case, always allow quoteCharacters, rawQuoteCharacters, | ||
| // and spaceCharacters to be escaped | ||
| var doubleQuoteChar = findElement(self.doubleQuoteCharacters, str[i]); |
There was a problem hiding this comment.
Does updating doubleQuoteChar here break quote matching? If doubleQuoteCharacters = ['"','$'], would this cause "\$" to fail with a missing close quote error?
There was a problem hiding this comment.
Nope, added a test showing that
|
@LinuxMercedes I'm going through my old open PRs. I assume you have no interest in this now so I should just decide myself if I want to close or merge it? |
|
Yeah, I ended up needing lower-level parser control for my usecase. Thanks for writing this, though! |
|
Abandoning this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will this fit your needs, @LinuxMercedes?
Review welcome as well if you so desire