Fix coverity memory leak issue #11144 as part of EUCA-4798.

eucalyptus · Jan 21, 2013 · 8155208 · 8155208
1 parent 530b86a
commit 8155208
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/cluster/server-marshal.c b/cluster/server-marshal.c
@@ -1356,8 +1356,6 @@ adb_RunInstancesResponse_t *RunInstancesMarshal(adb_RunInstances_t * runInstance
             rc = ccInstanceUnmarshal(it, myInstance, env);
             adb_runInstancesResponseType_add_instances(rirt, env, it);
         }
-        if (outInsts)
-            free(outInsts);
     }
 
     adb_runInstancesResponseType_set_correlationId(rirt, env, ccMeta.correlationId);
@@ -1374,9 +1372,8 @@ adb_RunInstancesResponse_t *RunInstancesMarshal(adb_RunInstances_t * runInstance
     free(netNames);
     free(instIds);
     free(userData);
-    if (uuids != NULL)
-        free(uuids);
-
+    free(uuids);
+    free(outInsts);
     return (ret);
 }