Update trivial-download.lisp #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the `(unless quiet` in `with-download` macro. The original version happens to be right because the same name `quiet` in the definition of `download` function, but will come to error if directly use `with-download` with `:quiet`. Add another option `:drakma-options` that may be helpful to send additional information when download, e.g. a fake header, cookies or user agent that may be helpful to download files in some websites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the
(unless quietinwith-downloadmacro. The original version happens to be right because the same namequietin the definition ofdownloadfunction, but will come to error if directly usewith-downloadwith:quiet. Add another option:drakma-optionsthat may be helpful to send additional information when download, e.g. a fake header, cookies or user agent that may be helpful to download files in some websites.